Bug 245761

Summary: textproc/kibana7 broken | incompatible with node10.20
Product: Ports & Packages Reporter: Sven Ruediger <admin>
Component: Individual Port(s)Assignee: Greg Lewis <glewis>
Status: Closed FIXED    
Severity: Affects Many People CC: 000.fbsd, admin, glewis
Priority: --- Flags: admin: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
files/patch-src_setup__node__env_validator.js
none
testport_poudriere_amd64
none
alternative 02_fixed_nodeversion.patch none

Description Sven Ruediger 2020-04-20 09:20:30 UTC 
Kibana won't start with current www/node10 (v10.20). (no errors in kibana.log)

when starting kibana without rc-script you'll get:
```
node /usr/local/www/kibana7/src/cli
Kibana does not support the current Node.js version v10.20.1. Please use Node.js v10.19.0.
```


(1) mark textproc/kibana7 as broken
(2) change runtime dependency to `node10=10.19.0 : www/node10`


I couldn't find any working fix except downgrading node10 to r528343
`portdowngrade www/node10 r528343`
Comment 1 Miroslav Lachman 2020-04-20 12:23:24 UTC 
It can be hardly solved. FreeBSD ports are updated by independent maintainers. Whenever new version of node10 is released it will be updated in the ports tree but nobody checks depended ports and their requirements.

You can try to edit /usr/local/www/kibana7/package.json

There is "node": "10.19.0"

If you set it to 10.20.0 maybe it will run, maybe not.
Comment 2 Sven Ruediger 2020-04-21 16:27:10 UTC 
Created attachment 213641 [details]
files/patch-src_setup__node__env_validator.js

(1) set node version to >=10.19 ()
  - Might cause any unknown issue if node is going to be updated again. At least we make sure that Node is 10.x in Makefile/RUN_DEPENDS=node10.
Comment 3 Sven Ruediger 2020-04-21 16:28:37 UTC 
Created attachment 213642 [details]
testport_poudriere_amd64
Comment 4 Sven Ruediger 2020-04-21 16:30:10 UTC 
Created attachment 213643 [details]
alternative 02_fixed_nodeversion.patch

(2) set version to (current upstream) 10.20.1 (alternative 02_fixed_nodeversion.patch)
  - this will break the port on next www/node10 update
Comment 5 Sven Ruediger 2020-04-21 16:31:40 UTC 
Thanks for the advice. Complaining about upstream dependencies won't fix that issue, this port is still broken.


I created and tested two possible hotfixes.

(1) set node version to >=10.19 (files/patch-src_setup__node__env_validator.js )
  - Might cause any unknown issue if node is going to be updated again. At least we make sure that Node is 10.x in Makefile/RUN_DEPENDS=node10.

OR

(2) set version to (current upstream) 10.20.1 (alternative 02_fixed_nodeversion.patch)
  - this will break the port on next www/node10 update

Testport for 1st solution is attached.
Comment 6 Miroslav Lachman 2020-04-21 19:24:46 UTC 
(In reply to Sven R from comment #5)
Build test with poudriere is not so important. The important is if somebody tested it, if it runs or not.

If some SW is tied to exact version of some interpreter or another dependency then it will always be a problem in ports tree.

The other solution can be bundled node in to Kibana port. It is really ugly but it is what upstream do for Linux / Mac / Windows distributed packages.
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-04-25 18:40:52 UTC 
A commit references this bug:

Author: glewis
Date: Sat Apr 25 18:39:55 UTC 2020
New revision: 532971
URL: https://svnweb.freebsd.org/changeset/ports/532971

Log:
  * Update to 7.6.2
  * Be more liberal about the version of node10 allowed [1]

  PR:		245761 [1]
  Submitted by:	Sven R <admin@hackacad.net> [1]

Changes:
  head/textproc/kibana7/Makefile
  head/textproc/kibana7/distinfo
  head/textproc/kibana7/files/patch-src_setup__node__env_node__version__validator.js
Comment 8 Greg Lewis freebsd_committer freebsd_triage 2020-04-25 18:42:53 UTC 
I tested Kibana with option 2 (allow any node version greater than 10.19) and it worked for me.