Bug 245920
| Summary: | [Patch] Add RSSI field to LE scan response | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Marc Veldman <marc> | ||||||
| Component: | wireless | Assignee: | Takanori Watanabe <takawata> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | emaste, hselasky, takawata | ||||||
| Priority: | --- | ||||||||
| Version: | CURRENT | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 246141 | ||||||||
| Attachments: |
|
||||||||
The data member is actually variable length, so adding rssi member to last is not match actual packet format. Isn't it better to add one more length to data member and comment that the data contains rssi? You are correct. That is the way to do it. I will update my patch. Thanks for the review! Created attachment 214297 [details]
Correct patch. Add space for rssi to data field.
A commit references this bug: Author: takawata Date: Sat May 9 14:15:44 UTC 2020 New revision: 360846 URL: https://svnweb.freebsd.org/changeset/base/360846 Log: Add space for RSSI in data member. RSSI is put just after actual data. Submitted by: Marc Veldman PR: 245920 Changes: head/sys/netgraph/bluetooth/include/ng_hci.h |
Created attachment 213797 [details] Add rssi field to ng_hci_le_advreport The ng_hci_le_advreport struct is missing the rssi field. Bluetooth Core Spec v5.2 Vol. 4, Part E, Section 7.7.65.2