Bug 246042
| Summary: | [NEW PORT] net/py-wsdd: Web Service Discovery host daemon | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Hiroo Ono <hiroo.ono+freebsd> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | diizzy, mandree, yasu | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Nice work! Perhaps be a bit more verbose about the description? COMMENT= Web Service Discovery (WSD) host daemon for Samba Shouldn't USES be python:3.5+,run as it's only a run dependency? https://svnweb.freebsd.org/ports/head/Mk/Uses/python.mk?revision=532396&view=markup#l39 Shouldn't NO_ARCH be set? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-arch.html Doesn't matter much but I think you can omit DOC_FILES as they doesn't provide any useful documentation. Manpage is missing, that should be installed. post-patch --> Shebangfix doesn't work? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-shebangfix.html Best regards, Daniel Created attachment 213940 [details]
wsdd port files (updated)
Thank you. Updated the patch according to your suggestions. Remove post-patch section as it's not needed
@${MKDIR} ${STAGEDIR}${DOCSDIR} isn't needed
While not in the handbook (yet?) I'm fairly sure that you need to use the prefix py- as mentioned here https://wiki.freebsd.org/Python/PortsPolicy#Prefixing_.28py-.2A.29 in package name (and directory).
Best regards,
Daniel
(In reply to daniel.engberg.lists from comment #4) Just to be clear about prefix, like this: https://svnweb.freebsd.org/ports/head/devel/py-six/Makefile?revision=524438&view=markup#l8 Created attachment 213968 [details]
wsdd port files (updated)
Sorry for my incomplete correction.
Updated the patch again.
Passes poudriere testport on 12.1-RELEASE (AMD64) A commit references this bug: Author: mandree Date: Sat May 2 17:57:00 UTC 2020 New revision: 533700 URL: https://svnweb.freebsd.org/changeset/ports/533700 Log: new port: net/py-wsdd, web service discovery host daemon wsdd implements a Web Service Discovery host daemon. This enables (Samba) hosts, like your local NAS device, to be found by Web Service Discovery Clients like Windows. WWW: https://github.com/christgau/wsdd PR: 246042 Submitted by: Hiroo Ono <hiroo.ono+freebsd@gmail.com> (maintainer) Changes: head/net/Makefile head/net/py-wsdd/ head/net/py-wsdd/Makefile head/net/py-wsdd/distinfo head/net/py-wsdd/pkg-descr head/net/py-wsdd/pkg-message *** Bug 246085 has been marked as a duplicate of this bug. *** |
Created attachment 213931 [details] wsdd port files wsdd is a Web Service Discovery host daemon that helps Windows hosts find Samba shares without SMB1/CIFS enabled. Since NetBIOS discovery is not supported by Windows anymore, wsdd makes hosts to appear in Windows again using the Web Service Discovery method.