Bug 246080

Summary: vt options mismatch
Product: Base System Reporter: David Marec <david.marec>
Component: kernAssignee: Mark Johnston <markj>
Status: Closed FIXED    
Severity: Affects Some People CC: bdrewery, cem, emaste, markj
Priority: --- Keywords: patch, vt
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
option VT_FB_DEFAULT_WIDTH replacement
none
man vt + kernel NOTES + kernel options none

Description David Marec 2020-05-01 10:11:00 UTC 
Created attachment 213980 [details]
option VT_FB_DEFAULT_WIDTH replacement

The commit 
https://svnweb.freebsd.org/base?view=revision&revision=303312 
replaced the  «framebuffer max size» id from `VT_FB_DEFAULT_WIDTH` to `VT_FB_MAX_WIDTH`.

Unless this tag  has been also switched in `sys/conf/options`, this  configuration option will never be populated.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-05-24 21:45:30 UTC 
Notify original committer.
Comment 2 Conrad Meyer freebsd_committer freebsd_triage 2020-05-29 17:57:45 UTC 
Ah, I had no idea they were config options.  Bug is present in CURRENT; patch is missing (trivial) sys/conf/NOTES update.
Comment 3 David Marec 2020-05-30 18:14:28 UTC 
Created attachment 215068 [details]
man vt + kernel NOTES + kernel options

Correct. Here is a path that reviews kernel NOTES.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-04 16:05:31 UTC 
A commit references this bug:

Author: markj
Date: Thu Jun  4 16:05:25 UTC 2020
New revision: 361792
URL: https://svnweb.freebsd.org/changeset/base/361792

Log:
  Update vt(4) config option names to chase r303043.

  PR:		246080
  Submitted by:	David Marec <david@lapinbilly.eu>
  MFC after:	1 week

Changes:
  head/share/man/man4/vt.4
  head/sys/conf/NOTES
  head/sys/conf/options
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-06-08 21:39:33 UTC 
A commit references this bug:

Author: markj
Date: Mon Jun  8 21:38:53 UTC 2020
New revision: 361942
URL: https://svnweb.freebsd.org/changeset/base/361942

Log:
  MFC r361792:
  Update vt(4) config option names to chase r303043.

  PR:	246080

Changes:
_U  stable/12/
  stable/12/share/man/man4/vt.4
  stable/12/sys/conf/NOTES
  stable/12/sys/conf/options
Comment 6 Mark Johnston freebsd_committer freebsd_triage 2020-06-08 21:52:21 UTC 
Thanks for the report and the patch.