Bug 246122
| Summary: | databases/rrdtool: rrdcached update rc script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dries Michiels <driesm> | ||||
| Component: | Individual Port(s) | Assignee: | Niclas Zeising <zeising> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | rudolphfroger | ||||
| Priority: | --- | Keywords: | buildisok | ||||
| Version: | Latest | Flags: | zeising:
maintainer-feedback+
zeising: merge-quarterly? |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/146761521 A commit references this bug: Author: zeising Date: Mon Jul 20 19:15:13 UTC 2020 New revision: 542669 URL: https://svnweb.freebsd.org/changeset/ports/542669 Log: databases/rrdtool: Don't hardcode in start script Upate the start script of the rrdtool component rrdcached to not hardcode things like group, socket and pid. These can now be overridden in /etc/rc.conf with rrdcached_group, rrdcached_address and rrdcached_pid, respectively. The defaults are still the same. PR: 246122 Submitted by: Dries Michiels MFH: 2020Q3 Changes: head/databases/rrdtool/Makefile head/databases/rrdtool/files/rrdcached.in Start script updated, sorry for sitting on this for so long. Awaiting MFH A commit references this bug: Author: zeising Date: Wed Jul 22 16:24:29 UTC 2020 New revision: 542872 URL: https://svnweb.freebsd.org/changeset/ports/542872 Log: MFH: r542669 databases/rrdtool: Don't hardcode in start script Upate the start script of the rrdtool component rrdcached to not hardcode things like group, socket and pid. These can now be overridden in /etc/rc.conf with rrdcached_group, rrdcached_address and rrdcached_pid, respectively. The defaults are still the same. PR: 246122 Submitted by: Dries Michiels Approved by: ports-secteam (joenum) Changes: _U branches/2020Q3/ branches/2020Q3/databases/rrdtool/Makefile branches/2020Q3/databases/rrdtool/files/rrdcached.in Merged. Thank you for your submission! |
Created attachment 214029 [details] rrdtool.diff This updates the rc script to not use rrdcached_flags as command_args. Now the basic arguments are passed always configurable with knobs in rc.conf. While rrdcached_flags now serves the purpose of "extra" non required flags that can be appended to command_args.