Bug 246241

Summary: www/riot-web: Update to 1.6.0
Product: Ports & Packages Reporter: Alexander Sieg <ports>
Component: Individual Port(s)Assignee: Hiroki Tagato <tagattie>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, tagattie
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/vector-im/riot-web/releases/tag/v1.6.0
Attachments:
Description Flags
Update to 1.6.0
none
Patch against current ports version ports: maintainer-approval+

Description Alexander Sieg 2020-05-05 20:44:34 UTC
Created attachment 214176 [details]
Update to 1.6.0
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-05-06 06:06:29 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 2 Hiroki Tagato freebsd_committer freebsd_triage 2020-05-06 07:37:09 UTC
Hi, thanks for maintaining this port.

I tried to apply the patch and failed. Can you make a patch against the latest version of the port tree? (The latest version of the port is 1.5.15.)
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-05-06 08:32:58 UTC
Hi Alexander,

Thanks for the patch! Additionally to the changes suggested by Hiroki, would you mind using the Github helpers we provide in the infrastructure?

Try this patch:

Index: Makefile
===================================================================
--- Makefile    (revision 534149)
+++ Makefile    (working copy)
@@ -4,7 +4,6 @@
 DISTVERSIONPREFIX=     v
 DISTVERSION=   1.5.15
 CATEGORIES=    www
-MASTER_SITES=  https://github.com/vector-im/riot-web/releases/download/${DISTVERSIONFULL}/
 PKGNAMESUFFIX= -web
 
 MAINTAINER=    ports@xanderio.de
@@ -12,6 +11,10 @@
 
 LICENSE=       APACHE20
 
+USE_GITHUB=    yes
+GH_ACCOUNT=    vector-im
+GH_PROJECT=    ${PORTNAME}${PKGNAMESUFFIX}
+
 NO_ARCH=       yes
 NO_BUILD=      yes

Thanks!
Comment 4 Alexander Sieg 2020-05-06 11:58:15 UTC
(In reply to Fernando Apesteguía from comment #3)
Yes i would mind as this would fetch the uncompiled source files and compiling these with npm or yarn is to my knowledge currently impossible from within the ports tree as there is no way to set ether of these tool into an offline mode or some way to provide the need dependencies.

This port is just an easy way to install the precompiled JS/HTML/CSS files.
Comment 5 Alexander Sieg 2020-05-06 12:02:49 UTC
Created attachment 214195 [details]
Patch against current ports version
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-05-07 10:58:40 UTC
A commit references this bug:

Author: tagattie
Date: Thu May  7 10:58:36 UTC 2020
New revision: 534257
URL: https://svnweb.freebsd.org/changeset/ports/534257

Log:
  Update to 1.6.0

  PR:		246241
  Submitted by:	Alexander Sieg <ports@xanderio.de> (maintainer)
  Approved by:	ehaupt (mentor)
  Changelog:	https://github.com/vector-im/riot-web/releases/tag/v1.6.0

Changes:
  head/www/riot-web/Makefile
  head/www/riot-web/distinfo
  head/www/riot-web/pkg-plist
Comment 7 Hiroki Tagato freebsd_committer freebsd_triage 2020-05-07 10:59:25 UTC
Committed, thanks!