Bug 246328

Summary: [RESTORE] net-p2p/nicotine-plus: New maintainer
Product: Ports & Packages Reporter: Daniel Menelkir <menelkir>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Not Accepted    
Severity: Affects Many People CC: daniel.engberg.lists, menelkir
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/Nicotine-Plus/nicotine-plus
Description Flags
menelkir: maintainer-approval+
menelkir: maintainer-approval+
Updated to 2.0.1
v14 none

Description Daniel Menelkir 2020-05-09 11:51:05 UTC
Created attachment 214308 [details]

Nicotine+ is a graphical client for the SoulSeek peer-to-peer system.
Comment 1 Daniel Menelkir 2020-05-18 21:29:04 UTC
Created attachment 214614 [details]

Bumped to 7af728a.

Lot's of things happened, they cleaned the code upstream.
Comment 2 Daniel Menelkir 2020-05-27 02:46:54 UTC
Created attachment 214894 [details]

Since there's no commiter review yet, I'll keep testing new commits from time to time. The work is going pretty well and the developers are improving the software, so I think' it's a good idea.

There's no final release yet, but the software is fine to use it. I'm testing myself from time to time.
Comment 3 Daniel Menelkir 2020-06-07 01:35:49 UTC
Created attachment 215303 [details]

Lots of fixes upstream. Some issues are now fixed upstream so there's no need to patch setup.py anymore.
Comment 4 Mikael Urankar freebsd_committer 2020-06-07 10:04:31 UTC
No need to define GH_PROJECT
There is no version 1.4.2 upstream, use DISTVERSION=	g2020XXXX instead (Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions)

I'm not sure you're allowed to remove the "Created by" line.
Have you asked acm@ to take over maintainership?
Comment 5 Daniel Menelkir 2020-06-07 14:07:55 UTC
(In reply to Mikael Urankar from comment #4)

Ask for a package deprecated more than 10 years?
Comment 6 Daniel Menelkir 2020-06-07 14:08:53 UTC
(In reply to Daniel Menelkir from comment #5)

Oh, my bad. nicotine++ was deprecated in 2013, nicotine was in 2009. Anyways, both was deprecated a long time ago.
Comment 7 Daniel Menelkir 2020-06-07 14:15:14 UTC
Created attachment 215318 [details]

(In reply to Mikael Urankar from comment #4)

Comment 8 Daniel Menelkir 2020-06-13 20:44:09 UTC
Created attachment 215528 [details]

Bumped to commit d5bdfa1.
Comment 9 Daniel Menelkir 2020-07-31 19:24:38 UTC
Created attachment 216913 [details]
Updated to 2.0.1

Updated to last stable: 2.0.1
Comment 10 daniel.engberg.lists 2020-07-31 19:54:04 UTC
Why is USES= tar:bz2 set if it's a tar.gz archive? This most likely also fixes why you need to set EXTRACT_SUFX in the first place.

Is you dependency list correct? Alpine, Arch and Void lists more deps....

Comment 11 Daniel Menelkir 2020-07-31 20:37:18 UTC
Created attachment 216917 [details]

(In reply to daniel.engberg.lists from comment #10)

Oops.. I was changing from using a commit to a release and forgot to remove some things, my bad. It's fixed now
Miniupnp wasn't working with my tests, maybe it's my setup. I've added the missing gobject too.
Comment 12 daniel.engberg.lists 2020-07-31 21:43:59 UTC
Have a look at Example 5.39, I think that'll reduce quite a bit of code.

Give Poudriere a run as your port needs to build using it. It'll also catch dependency issues among other things.
Comment 13 Daniel Menelkir 2020-07-31 23:59:03 UTC
(In reply to daniel.engberg.lists from comment #12)

I can't see the new deps, am I missing something?
About the code size, afaik the old commiter code had way more code than mine that now is just quite tiny, you mean the python variables? I don't know how could be improved.
But fine, I'll just give up trying to bring nicotine back.
Comment 14 daniel.engberg.lists 2020-08-01 00:27:57 UTC
Instead of doing .if statments you could use OPTION_RUN_DEPENDS= XXX instead.

GTK(+)3 is missing?

Is it intentional to have all options removed?

You're making good progress, it's easy to miss dependencies especially if you're only testing on a non clean system hence why I recommended using poudriere.
Comment 15 Daniel Menelkir 2020-08-01 18:02:29 UTC
(In reply to daniel.engberg.lists from comment #14)

My copy doesn't have any .if statements, only the original one from 2013 had.

GeoIP is pretty much useless for nicotine nowadays since that geoblock doesn't work as expected anymore. Without mutagen, most searches become unclean because nicotine isn't able to read id3.
Comment 16 daniel.engberg.lists 2020-08-01 19:49:44 UTC
I see and I apologize for reading diffs sloppy :/
So just to be clear GTK3 is unnecessary?
Comment 17 Daniel Menelkir 2020-08-01 23:36:41 UTC
Created attachment 216948 [details]

Added the gtk30 missing USE.
Comment 18 Daniel Menelkir 2020-10-16 07:50:22 UTC
I'll try to update this today.
Comment 19 Daniel Menelkir 2020-10-16 12:29:51 UTC
Created attachment 218797 [details]

Bumped to 2.1.2.
Comment 20 Daniel Menelkir 2020-11-30 13:35:10 UTC
Should I gave up on this port?
Comment 21 daniel.engberg.lists 2020-12-12 07:13:56 UTC
I don't think so, have you tried your patch using poudriere?
Having a quick look it seems you're missing plist?
Comment 22 Daniel Menelkir 2021-01-22 13:33:26 UTC
(In reply to daniel.engberg.lists from comment #21)
The name is also wrong, I'll close this one and open as a new name since it fits better. Also, at this point I've rewritten and there's nothing left from the original author of this port.
Comment 23 Daniel Menelkir 2021-01-22 13:39:23 UTC
Created attachment 221812 [details]

(In reply to Daniel Menelkir from comment #22)
Nevermind, they'll not change the name. Sigh.
Anyways, here's my last patch from zero (since the difference is way so far from the abandoned port from 7 years ago), It's being since may/2020 that I'm trying to adopt this port and I don't see this going anywhere.
Comment 24 Daniel Menelkir 2021-03-13 22:59:06 UTC
Created attachment 223242 [details]

Bumped to last release.
Comment 25 Daniel Menelkir 2021-03-13 22:59:52 UTC
I'll reopen this since there's more people interested on this port.
Comment 26 Dmitry Marakasov freebsd_committer 2021-03-17 10:57:31 UTC
Fails to install

===>  Staging for nicotine-plus-3.0.2
===>   nicotine-plus-3.0.2 depends on package: py37-mutagen>0 - found
===>   nicotine-plus-3.0.2 depends on package: py37-gobject3>0 - found
===>   nicotine-plus-3.0.2 depends on package: py37-gdbm>0 - found
===>   nicotine-plus-3.0.2 depends on package: py37-miniupnpc>0 - found
===>   nicotine-plus-3.0.2 depends on package: py37-setuptools>0 - found
===>   nicotine-plus-3.0.2 depends on file: /usr/local/bin/python3.7 - found
===>   Generating temporary packing list
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
sh: msgfmt: not found
running install
writing byte-compilation script '/tmp/tmpw_b3x7u6.py'
/usr/local/bin/python3.7 /tmp/tmpw_b3x7u6.py
removing /tmp/tmpw_b3x7u6.py
running install_data
error: can't copy 'mo/hu/LC_MESSAGES/nicotine.mo': doesn't exist or not a regular file
*** Error code 1

make: stopped in /usr/ports/net-p2p/nicotine-plus
Comment 27 Daniel Menelkir 2021-03-17 13:27:57 UTC
Created attachment 223361 [details]

I forgot gettext in USES.
Comment 28 Dmitry Marakasov freebsd_committer 2021-03-17 19:44:42 UTC
This probably only needs gettext-tools.

Now if fails on staging:

====> Running Q/A tests (stage-qa)
Error: Package names are not unique with flavors:
py37: nicotine-plus-3.0.2
py38: nicotine-plus-3.0.2
py39: nicotine-plus-3.0.2
Error: maybe use <flavor>_PKGNAMEPREFIX/SUFFIX.

Please ensure that the port builds successfully in poudriere before the next submission.
Comment 29 Daniel Menelkir 2021-03-18 00:22:51 UTC
Created attachment 223376 [details]

Here's my fix.