Bug 246328
| Summary: | [RESTORE] net-p2p/nicotine-plus: New maintainer | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Menelkir <menelkir> | ||||||||||||||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||||||||||||||||||
| Status: | Closed Not Accepted | ||||||||||||||||||||||||||||||||
| Severity: | Affects Many People | CC: | daniel.engberg.lists, menelkir | ||||||||||||||||||||||||||||||
| Priority: | --- | ||||||||||||||||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||||||||||||||
| URL: | https://github.com/Nicotine-Plus/nicotine-plus | ||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||
Created attachment 214614 [details]
nicotine-v2.diff
Bumped to 7af728a.
Lot's of things happened, they cleaned the code upstream.
Created attachment 214894 [details]
nicotine-v3.diff
Since there's no commiter review yet, I'll keep testing new commits from time to time. The work is going pretty well and the developers are improving the software, so I think' it's a good idea.
There's no final release yet, but the software is fine to use it. I'm testing myself from time to time.
Created attachment 215303 [details]
nicotine-v4.diff
Lots of fixes upstream. Some issues are now fixed upstream so there's no need to patch setup.py anymore.
No need to define GH_PROJECT
add LICENSE_FILE= ${WRKSRC}/COPYING
There is no version 1.4.2 upstream, use DISTVERSION= g2020XXXX instead (Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions)
I'm not sure you're allowed to remove the "Created by" line.
Have you asked acm@ to take over maintainership?
(In reply to Mikael Urankar from comment #4) Ask for a package deprecated more than 10 years? (In reply to Daniel Menelkir from comment #5) Oh, my bad. nicotine++ was deprecated in 2013, nicotine was in 2009. Anyways, both was deprecated a long time ago. Created attachment 215318 [details] nicotine-v5.diff (In reply to Mikael Urankar from comment #4) Fixed. Created attachment 215528 [details]
nicotine-v6.diff
Bumped to commit d5bdfa1.
Created attachment 216913 [details]
Updated to 2.0.1
Updated to last stable: 2.0.1
Why is USES= tar:bz2 set if it's a tar.gz archive? This most likely also fixes why you need to set EXTRACT_SUFX in the first place. Is you dependency list correct? Alpine, Arch and Void lists more deps.... https://pkgs.alpinelinux.org/package/edge/testing/x86_64/nicotine-plus https://www.archlinux.org/packages/community/any/nicotine+/ https://github.com/void-linux/void-packages/blob/master/srcpkgs/nicotine%2B/template Created attachment 216917 [details] nicotine-v8.diff (In reply to daniel.engberg.lists from comment #10) Oops.. I was changing from using a commit to a release and forgot to remove some things, my bad. It's fixed now Miniupnp wasn't working with my tests, maybe it's my setup. I've added the missing gobject too. Have a look at Example 5.39, I think that'll reduce quite a bit of code. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html Give Poudriere a run as your port needs to build using it. It'll also catch dependency issues among other things. (In reply to daniel.engberg.lists from comment #12) I can't see the new deps, am I missing something? About the code size, afaik the old commiter code had way more code than mine that now is just quite tiny, you mean the python variables? I don't know how could be improved. But fine, I'll just give up trying to bring nicotine back. Instead of doing .if statments you could use OPTION_RUN_DEPENDS= XXX instead. GTK(+)3 is missing? Is it intentional to have all options removed? You're making good progress, it's easy to miss dependencies especially if you're only testing on a non clean system hence why I recommended using poudriere. (In reply to daniel.engberg.lists from comment #14) My copy doesn't have any .if statements, only the original one from 2013 had. GeoIP is pretty much useless for nicotine nowadays since that geoblock doesn't work as expected anymore. Without mutagen, most searches become unclean because nicotine isn't able to read id3. I see and I apologize for reading diffs sloppy :/ So just to be clear GTK3 is unnecessary? Created attachment 216948 [details]
nicotine-v9.diff
Added the gtk30 missing USE.
I'll try to update this today. Created attachment 218797 [details]
nicotine-v10.diff
Bumped to 2.1.2.
Should I gave up on this port? I don't think so, have you tried your patch using poudriere? Having a quick look it seems you're missing plist? (In reply to daniel.engberg.lists from comment #21) The name is also wrong, I'll close this one and open as a new name since it fits better. Also, at this point I've rewritten and there's nothing left from the original author of this port. Created attachment 221812 [details] nicotine-v11.diff (In reply to Daniel Menelkir from comment #22) Nevermind, they'll not change the name. Sigh. Anyways, here's my last patch from zero (since the difference is way so far from the abandoned port from 7 years ago), It's being since may/2020 that I'm trying to adopt this port and I don't see this going anywhere. Created attachment 223242 [details]
v12
Bumped to last release.
I'll reopen this since there's more people interested on this port. Fails to install ===> Staging for nicotine-plus-3.0.2 ===> nicotine-plus-3.0.2 depends on package: py37-mutagen>0 - found ===> nicotine-plus-3.0.2 depends on package: py37-gobject3>0 - found ===> nicotine-plus-3.0.2 depends on package: py37-gdbm>0 - found ===> nicotine-plus-3.0.2 depends on package: py37-miniupnpc>0 - found ===> nicotine-plus-3.0.2 depends on package: py37-setuptools>0 - found ===> nicotine-plus-3.0.2 depends on file: /usr/local/bin/python3.7 - found ===> Generating temporary packing list sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found sh: msgfmt: not found running install ... writing byte-compilation script '/tmp/tmpw_b3x7u6.py' /usr/local/bin/python3.7 /tmp/tmpw_b3x7u6.py removing /tmp/tmpw_b3x7u6.py running install_data error: can't copy 'mo/hu/LC_MESSAGES/nicotine.mo': doesn't exist or not a regular file *** Error code 1 Stop. make: stopped in /usr/ports/net-p2p/nicotine-plus Created attachment 223361 [details]
v13
I forgot gettext in USES.
This probably only needs gettext-tools. Now if fails on staging: ====> Running Q/A tests (stage-qa) Error: Package names are not unique with flavors: py37: nicotine-plus-3.0.2 py38: nicotine-plus-3.0.2 py39: nicotine-plus-3.0.2 Error: maybe use <flavor>_PKGNAMEPREFIX/SUFFIX. Please ensure that the port builds successfully in poudriere before the next submission. Created attachment 223376 [details]
v14
Here's my fix.
|
Created attachment 214308 [details] nicotine.diff Nicotine+ is a graphical client for the SoulSeek peer-to-peer system.