Bug 246328

Summary: [RESTORE] net-p2p/nicotine-plus: New maintainer
Product: Ports & Packages Reporter: Daniel Menelkir <menelkir>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Overcome By Events    
Severity: Affects Many People CC: daniel.engberg.lists, menelkir, mikael
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/Nicotine-Plus/nicotine-plus
Attachments:
Description Flags
nicotine.diff
none
nicotine-v2.diff
none
nicotine-v3.diff
none
nicotine-v4.diff
menelkir: maintainer-approval+
nicotine-v5.diff
none
nicotine-v6.diff
menelkir: maintainer-approval+
Updated to 2.0.1
none
nicotine-v8.diff
none
nicotine-v9.diff none

Description Daniel Menelkir 2020-05-09 11:51:05 UTC
Created attachment 214308 [details]
nicotine.diff

Nicotine+ is a graphical client for the SoulSeek peer-to-peer system.
Comment 1 Daniel Menelkir 2020-05-18 21:29:04 UTC
Created attachment 214614 [details]
nicotine-v2.diff

Bumped to 7af728a.

Lot's of things happened, they cleaned the code upstream.
Comment 2 Daniel Menelkir 2020-05-27 02:46:54 UTC
Created attachment 214894 [details]
nicotine-v3.diff

Since there's no commiter review yet, I'll keep testing new commits from time to time. The work is going pretty well and the developers are improving the software, so I think' it's a good idea.

There's no final release yet, but the software is fine to use it. I'm testing myself from time to time.
Comment 3 Daniel Menelkir 2020-06-07 01:35:49 UTC
Created attachment 215303 [details]
nicotine-v4.diff

Lots of fixes upstream. Some issues are now fixed upstream so there's no need to patch setup.py anymore.
Comment 4 Mikael Urankar freebsd_committer 2020-06-07 10:04:31 UTC
No need to define GH_PROJECT
add LICENSE_FILE=   ${WRKSRC}/COPYING
There is no version 1.4.2 upstream, use DISTVERSION=	g2020XXXX instead (Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions)

I'm not sure you're allowed to remove the "Created by" line.
Have you asked acm@ to take over maintainership?
Comment 5 Daniel Menelkir 2020-06-07 14:07:55 UTC
(In reply to Mikael Urankar from comment #4)

Ask for a package deprecated more than 10 years?
Comment 6 Daniel Menelkir 2020-06-07 14:08:53 UTC
(In reply to Daniel Menelkir from comment #5)

Oh, my bad. nicotine++ was deprecated in 2013, nicotine was in 2009. Anyways, both was deprecated a long time ago.
Comment 7 Daniel Menelkir 2020-06-07 14:15:14 UTC
Created attachment 215318 [details]
nicotine-v5.diff

(In reply to Mikael Urankar from comment #4)

Fixed.
Comment 8 Daniel Menelkir 2020-06-13 20:44:09 UTC
Created attachment 215528 [details]
nicotine-v6.diff

Bumped to commit d5bdfa1.
Comment 9 Daniel Menelkir 2020-07-31 19:24:38 UTC
Created attachment 216913 [details]
Updated to 2.0.1

Updated to last stable: 2.0.1
Comment 10 daniel.engberg.lists 2020-07-31 19:54:04 UTC
Why is USES= tar:bz2 set if it's a tar.gz archive? This most likely also fixes why you need to set EXTRACT_SUFX in the first place.

Is you dependency list correct? Alpine, Arch and Void lists more deps....

https://pkgs.alpinelinux.org/package/edge/testing/x86_64/nicotine-plus
https://www.archlinux.org/packages/community/any/nicotine+/
https://github.com/void-linux/void-packages/blob/master/srcpkgs/nicotine%2B/template
Comment 11 Daniel Menelkir 2020-07-31 20:37:18 UTC
Created attachment 216917 [details]
nicotine-v8.diff

(In reply to daniel.engberg.lists from comment #10)

Oops.. I was changing from using a commit to a release and forgot to remove some things, my bad. It's fixed now
Miniupnp wasn't working with my tests, maybe it's my setup. I've added the missing gobject too.
Comment 12 daniel.engberg.lists 2020-07-31 21:43:59 UTC
Have a look at Example 5.39, I think that'll reduce quite a bit of code.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

Give Poudriere a run as your port needs to build using it. It'll also catch dependency issues among other things.
Comment 13 Daniel Menelkir 2020-07-31 23:59:03 UTC
(In reply to daniel.engberg.lists from comment #12)

I can't see the new deps, am I missing something?
About the code size, afaik the old commiter code had way more code than mine that now is just quite tiny, you mean the python variables? I don't know how could be improved.
But fine, I'll just give up trying to bring nicotine back.
Comment 14 daniel.engberg.lists 2020-08-01 00:27:57 UTC
Instead of doing .if statments you could use OPTION_RUN_DEPENDS= XXX instead.

GTK(+)3 is missing?

Is it intentional to have all options removed?

You're making good progress, it's easy to miss dependencies especially if you're only testing on a non clean system hence why I recommended using poudriere.
Comment 15 Daniel Menelkir 2020-08-01 18:02:29 UTC
(In reply to daniel.engberg.lists from comment #14)

My copy doesn't have any .if statements, only the original one from 2013 had.

GeoIP is pretty much useless for nicotine nowadays since that geoblock doesn't work as expected anymore. Without mutagen, most searches become unclean because nicotine isn't able to read id3.
Comment 16 daniel.engberg.lists 2020-08-01 19:49:44 UTC
I see and I apologize for reading diffs sloppy :/
So just to be clear GTK3 is unnecessary?
Comment 17 Daniel Menelkir 2020-08-01 23:36:41 UTC
Created attachment 216948 [details]
nicotine-v9.diff

Added the gtk30 missing USE.