Bug 246387
| Summary: | www/chromium: Synchronization stopped working a few versions back | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Joseph Mingrone <jrm> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-chromium (Nobody) <chromium> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | donaldcallen, emaste, jonc, lme, robert | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(chromium) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Mingrone
2020-05-11 20:07:22 UTC
I am also seeing this problem and it is a serious one. Firefox does not work well on FreeBSD (or on Linux, for that matter) frequently becoming unresponsive requiring manual killing and a restart. Chromium does not exhibit these problems on my Linux systems, but I can't use it on FreeBSD because of this issue. (In reply to donaldcallen from comment #1) It's serious, but keep in mind that (1) Chromium is not officially supported on FreeBSD, (2) upstream has be resistant to working with us, and (3) this is all a volunteer effort. For (1), I don't have direct information, but have heard it from other FreeBSD developers. Our Chromium port currently has over 800 local patches and I'm told there have been attempts to upstream some, but these requests were rejected. If you are available, we can always use more volunteers to help keep Chromium in the best shape possible. Thanks for the response. I understand the problem better per your message. The good news is I'm a very experienced software guy (I wrote my first line of code in 1960, which is a really frightening thought), but Chromium is such a rat's next, I think it's unlikely I can help. But I'll have a look and if I can make any headway, I'll get back. One thought: OpenBSD has chromium 81 available as a package and while their packages aren't as carefully scrutinized as the core system, OpenBSD stuff usually works. I can do a test install and see how well sync works. If it does, it might provide some help in getting the FreeBSD version working. I was just looking at the OpenBSD port as well. They have 1934 local patches! Some may be related to adopting their Chromium to use pledge. Any free time you can spare would be appreciated. :) Cheers, Joe Duplicate of bug 244185? Maybe same issue relating to API key as bug 233095. OpenBSD was suffering from the same issue. The fix is here: https://marc.info/?l=openbsd-ports-cvs&m=159289397828827&w=2 Created attachment 215923 [details]
Adapted Patch from OpenBSD
So I had a look at the OpenBSD patches and converted the 2 patches that I believed were relevant, ie: SysInfo::GetHardwareInfo() and the invocation of the GetHardwareInfo().
However, my initial testing failed to indicate that sync was working. My test-methodology involved:
1. removing ~/.config/chromium
2. start up chrome, enable sync with chrome-login
3. wait for 5 minutes
Unfortunately, nothing happened.
Looking at chrome://sync-internals/ the "Transport State" was still stuck at "Configuring data types".
Maybe more patches need to be converted?
You also need this bit:
diff --git a/www/chromium/patches/patch-base_system_sys_info_cc b/www/chromium/patches/patch-base_system_sys_info_cc
new file mode 100644
index 00000000000..d39d993530d
--- /dev/null
+++ b/www/chromium/patches/patch-base_system_sys_info_cc
@@ -0,0 +1,14 @@
+$OpenBSD: patch-base_system_sys_info_cc,v 1.1 2020/06/23 06:32:53 robert Exp $
+
+Index: base/system/sys_info.cc
+--- base/system/sys_info.cc.orig
++++ base/system/sys_info.cc
+@@ -102,7 +102,7 @@ void SysInfo::GetHardwareInfo(base::OnceCallback<void(
+ #elif defined(OS_ANDROID) || defined(OS_MACOSX)
+ base::ThreadPool::PostTaskAndReplyWithResult(
+ FROM_HERE, {}, base::BindOnce(&GetHardwareInfoSync), std::move(callback));
+-#elif defined(OS_LINUX)
++#elif defined(OS_LINUX) || defined(OS_BSD)
+ base::ThreadPool::PostTaskAndReplyWithResult(
+ FROM_HERE, {base::MayBlock()}, base::BindOnce(&GetHardwareInfoSync),
+ std::move(callback));
Robert, thank you for your help on this. Donald and Jonathan, there is a (still untested) review at https://reviews.freebsd.org/D25449 if you want to test if synchronization is working with it. As far as I can tell, synchronization is working as it should with that update. A commit references this bug: Author: jrm Date: Fri Jun 26 00:43:53 UTC 2020 New revision: 540411 URL: https://svnweb.freebsd.org/changeset/ports/540411 Log: www/chromium: Update to 83.0.4103.106 and fix synchronization PR: 244185, 246387 Reported by: bourne.identity@hotmail.com Approved by: chromium@ (rene), cem Obtained from: Robert Nagy via OpenBSD port MFH: 2020Q2 Security: https://www.vuxml.org/freebsd/6a5d15b6-b661-11ea-8015-e09467587c17.html Differential Revision: https://reviews.freebsd.org/D25449 Changes: head/www/chromium/Makefile head/www/chromium/distinfo head/www/chromium/files/patch-base_system_sys__info.cc head/www/chromium/files/patch-base_system_sys__info__freebsd.cc head/www/chromium/files/patch-components_sync__device__info_device__info__sync__bridge.cc Jonathan. Thank you for your patch, which I am just seeing now. Synchronization seems to be working now. If you see more problems, please re-open this bug or a new one. Robert, thank you again for sharing what you discovered with the OpenBSD port. A commit references this bug: Author: jrm Date: Fri Jun 26 08:44:33 UTC 2020 New revision: 540450 URL: https://svnweb.freebsd.org/changeset/ports/540450 Log: MFH: r540411 www/chromium: Update to 83.0.4103.106 and fix synchronization PR: 244185, 246387 Reported by: bourne.identity@hotmail.com Approved by: ports-secteam (implicit), chromium@ (rene), cem Obtained from: Robert Nagy via OpenBSD port Security: https://www.vuxml.org/freebsd/6a5d15b6-b661-11ea-8015-e09467587c17.html Differential Revision: https://reviews.freebsd.org/D25449 Changes: _U branches/2020Q2/ branches/2020Q2/www/chromium/Makefile branches/2020Q2/www/chromium/distinfo branches/2020Q2/www/chromium/files/patch-base_system_sys__info.cc branches/2020Q2/www/chromium/files/patch-base_system_sys__info__freebsd.cc branches/2020Q2/www/chromium/files/patch-components_sync__device__info_device__info__sync__bridge.cc |