Bug 246431
| Summary: | games/bzflag: Update to 2.4.20 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kevin Zheng <kevinz5000> | ||||||||
| Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | fernape, tagattie | ||||||||
| Priority: | --- | Flags: | kevinz5000:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval Attachment -> Details -> maintainer-approval [+] Thanks! Not aware I could do that; thanks! Created attachment 214479 [details]
Poudriere failed build log
Hi,
I tried to build the port and failed with the following message (a full build log attached):
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: bin/bzflag
===> Error: Plist issues found.
*** Error code 1
Stop.
Can you check?
Hey, thanks for checking. I'm a little confused why this is happening; it seems like your build log suggests that CLIENT="" for plist_sub, but bzflag (the binary that is built only when CLIENT is enabled) is being installed. For me, games/bzflag and games/bzflag-server both pass `make check-plist`. Could you check if you can `make check-plist` without poudriere? Then, at least we can find out why I'm not seeing the problem. (In reply to Kevin Zheng from comment #4) I tried a build without poudriere and got exactly the same error. There is the following line in the attached build log: configure: WARNING: Client build is enabled, but OpenGL does not seem to be fully available ... disabling BZFlag client This may be some clue... Okay, thanks for the clue. It sounds like I could have a local library that's not correctly set in USES. I'll look; thanks. Created attachment 214494 [details]
Patch
I think it was missing USES_GL=glew.
I've also added some USES_XORG components for good measure (shown by ldd on the compiled executable).
A commit references this bug: Author: tagattie Date: Sat May 16 04:41:49 UTC 2020 New revision: 535351 URL: https://svnweb.freebsd.org/changeset/ports/535351 Log: Update to 2.4.20 PR: 246431 Submitted by: Kevin Zheng <kevinz5000@gmail.com> (maintainer) Approved by: ehaupt (mentor) Changelog: https://www.bzflag.org/downloads/#changelog Changes: head/games/bzflag/Makefile head/games/bzflag/distinfo head/games/bzflag/pkg-plist Committed, thanks! |
Created attachment 214440 [details] Patch games/bzflag: Update to 2.4.20