Bug 246507
| Summary: | games/netrek-client-cow: Update to 3.3.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kevin Zheng <kevinz5000> | ||||||
| Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | fernape, tagattie | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | kevinz5000:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi,
I tried to build the port with poudriere and got the following warning during stage-qa:
====> Running Q/A tests (stage-qa)
Warning: 'bin/netrek-client-cow' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error: /usr/local/bin/netrek-client-cow is linked to /usr/local/lib/libX11.so.6 from x11/libX11 but it is not declared as a dependency
Warning: you need USE_XORG+=x11
Error: /usr/local/bin/netrek-client-cow is linked to /usr/local/lib/libXxf86vm.so.1 from x11/libXxf86vm but it is not declared as a dependency
Warning: you need USE_XORG+=xxf86vm
Can you update the patch to address those messages?
Created attachment 215269 [details]
Patch
Thanks for checking; I was missing all the explicit X11 dependencies. I've added these and manually stripped the binary (the port uses a custom Makefile).
A commit references this bug: Author: tagattie Date: Sun Jun 7 06:02:07 UTC 2020 New revision: 538143 URL: https://svnweb.freebsd.org/changeset/ports/538143 Log: - Update to 3.3.2 - Make portclippy/portfmt happy PR: 246507 Submitted by: Kevin Zheng <kevinz5000@gmail.com> (maintainer) Approved by: mentors (implicit) Changelog: https://github.com/quozl/netrek-client-cow/blob/3.3.2/ChangeLog Changes: head/games/netrek-client-cow/Makefile head/games/netrek-client-cow/distinfo head/games/netrek-client-cow/files/patch-parsemeta.c head/games/netrek-client-cow/files/patch-system.mk.in Committed, thanks! |
Created attachment 214556 [details] Patch games/netrek-client-cow: Update to 3.3.2