Bug 246524
| Summary: | www/luakit-devel: update to 2.1.36 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Marco Beishuizen <mbeis> | ||||||||
| Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | fernape, tagattie | ||||||||
| Priority: | --- | Flags: | mbeis:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval Attachment -> Details -> maintainer-approval [+] Thanks! The attached patch does not seem to apply cleanly. Can you regenerate a patch against the latest revision of www/luakit-devel? (The attached on appears to be against www/luakit.) I updated the portstree but www/luakit-devel seems to be empty now? (In reply to Marco Beishuizen from comment #3) What command do you use to update the ports tree? - If you use portsnap, do: $ portsnap auto or $ portsnap fetch update - If you use subversion, do: $ cd /path/to/ports/tree && svn update I use subversion (svn update /usr/ports). Don't know why but www/luakit-devel stays empty. I'll try to checkout the tree again. When I delete www/luakit-devel and checkout again, svn says that www/luakit-devel is restored but the directory stays empty. (In reply to Marco Beishuizen from comment #7) What's the output of: $ svn status -v www/luakit-devel [root@yokozuna:/usr/ports]# svn status -v www/luakit-devel R 535855 ? ? www/luakit-devel D 535855 531946 tcberner www/luakit-devel/Makefile D 535855 531946 tcberner www/luakit-devel/distinfo D 535855 515209 pi www/luakit-devel/pkg-descr D 535855 531946 tcberner www/luakit-devel/pkg-plist (In reply to Marco Beishuizen from comment #9) Thanks for the output. It appears subversion thinks the files are deleted. Can you try: # svn revert -R www/luakit-devel I guess that will revive the files in the directory. Thanks!, the port is back. I'll create a new diff for the upgrade. Created attachment 214637 [details]
www/luakit-devel: update to 2.1.36
www/luakit-devel: update to 2.1.36
I tried to build the port with poudriere and got the following warning message:
====> Running Q/A tests (stage-qa)
Warning: 'lib/luakit/luakit.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
It appears luakit.so need to be stripped as well as luakit.
I don't get any warning here. When "INSTALL_TARGET=install-strip" is added to the Makefile, installing fails with:
[...]
===> Generating temporary packing list
gmake[2]: Entering directory '/home/marco/devel/_freebsd/ports/www/luakit-devel/work/luakit-2.1-36-ga188409'
gmake[2]: *** No rule to make target 'install-strip'. Stop.
gmake[2]: Leaving directory '/home/marco/devel/_freebsd/ports/www/luakit-devel/work/luakit-2.1-36-ga188409'
*** Error code 2
Stop.
make[1]: stopped in /home/marco/devel/_freebsd/ports/www/luakit-devel
*** Error code 1
Stop.
make: stopped in /home/marco/devel/_freebsd/ports/www/luakit-devel
[...]
Notice that the Makefile already has:
[...]
post-install:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/luakit
[...]
So I'm not sure what to do next.
After adding "DEVELOPER=yes" to make.conf the warning is visible. Still finding out how to get rid of the warning though. (In reply to Marco Beishuizen from comment #15) Adding the following line to post-install target should be enough: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/luakit/luakit.so Created attachment 214692 [details]
www/luakit-devel: update to 2.1.36
This should fix it.
A commit references this bug: Author: tagattie Date: Thu May 21 05:21:26 UTC 2020 New revision: 536070 URL: https://svnweb.freebsd.org/changeset/ports/536070 Log: - Update to 2.1.36 - Make portclippy happy PR: 246524 Submitted by: Marco Beishuizen <mbeis@xs4all.nl> (maintainer) Approved by: mentors (implicit) Changes: head/www/luakit-devel/Makefile head/www/luakit-devel/distinfo Commited, thanks! |
Created attachment 214582 [details] www/luakit-devel: update to 2.1.36 Update luakit development version to 2.1.36