Bug 246562
| Summary: | textproc/linuxdoc-tools: Update to 0.9.80 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Felix Palmen <zirias> | ||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | fernape | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Felix Palmen
2020-05-19 06:40:15 UTC
Por builds fine, but then, when running linuxdoc: $ linuxdoc Can't locate LinuxDocTools/Utils.pm in @INC (you may need to install the LinuxDocTools::Utils module) (@INC contains: /usr/local/lib/perl5/site_perl/mach/5.30 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.30/mach /usr/local/lib/perl5/5.30) at /usr/local/bin/linuxdoc line 15. BEGIN failed--compilation aborted at /usr/local/bin/linuxdoc line 15. Would you mind having a look a this? Comment on attachment 214620 [details]
update to 0.9.79
Of course I will look into this! Didn't expect such breakage as the latest updates were all fine, and my bulk build is still running, so it will take a while, thanks for alerting.
Created attachment 214640 [details] update to 0.9.79 with added patch The new version tries to use LinuxDocTools/Utils.pm before setting its own library path. I have no idea how this should work, therefore created an upstream issue here: https://gitlab.com/agmartin/linuxdoc-tools/-/issues/12 For now I added a patch changing the order of lines in the linuxdoc script, which fixes this issue. I would approve this patch after a few test builds. Build testing... Upstream author reacted on my issue by fixing it and releasing 0.9.80. So, doesn't make sense to commit right now, as we can avoid the local patch skipping 0.9.79 :) Created attachment 214647 [details]
update to 0.9.80
Here's the update to 0.9.80 instead. Changed MASTER_SITES to download directly from gitlab as the Debian mirror is a bit behind. Local build and test ok, will do additional poudriere tests soon.
Thanks! Could you please, update the patch so it is in Unix text format? file ~/Downloads/0980.txt /home/fernape/Downloads/0980.txt: unified diff output, ASCII text, with CRLF line terminators Builds fine ni {11.3,12.1}{amd64,i386} and 13-current amd64.
Runs fine in 12.1 amd64
(In reply to Fernando Apesteguía from comment #7) FWIW, CRLF in a media type text/* according to MIME is correct, see RFC2046, section 4.1.1 -- but it seems bugzilla only uses CRLF when you paste the patch in the text field for upload (as I did with this last patch). When doing an HTTP upload, it just uses whatever is uploaded literally (so LF only when the file was created on a *nix machine). Maybe tools like fetch should convert line endings automatically for text/* media types… Are you sure another attachment here will do any good here? (In reply to Felix Palmen from comment #9) No need. It builds and works :-) (In reply to Fernando Apesteguía from comment #10) Thanks for doing all the tests, I was still waiting for my builder machine to become available again :) A commit references this bug: Author: fernape Date: Wed May 20 05:39:53 UTC 2020 New revision: 535972 URL: https://svnweb.freebsd.org/changeset/ports/535972 Log: textproc/linuxdoc-tools: Update to 0.9.80 PR: 246562 Submitted by: felix@palmen-it.de (maintainer) Changes: head/textproc/linuxdoc-tools/Makefile head/textproc/linuxdoc-tools/distinfo head/textproc/linuxdoc-tools/pkg-descr Committed, Thanks! |