Bug 246681

Summary: shells/fish: update to 3.1.2 and fix upstream #6955
Product: Ports & Packages Reporter: Dave Cottlehuber <dch>
Component: Individual Port(s)Assignee: Alan Somers <asomers>
Status: Closed FIXED    
Severity: Affects Many People CC: dch
Priority: --- Flags: bugzilla: maintainer-feedback? (asomers)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1 patch none

Description Dave Cottlehuber freebsd_committer freebsd_triage 2020-05-23 17:10:37 UTC
Created attachment 214787 [details]
v1 patch

upstream issue https://github.com/fish-shell/fish-shell/issues/6955 breaks many many things, including $EDITOR support.

tested w poudriere on 12.1R amd64 + 13.0-CURRENT amd64 also.

if reqd should be merged to quarterly as well, as the bug is pretty nasty.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2020-05-24 20:10:25 UTC
I'm testing it now.  I won't MFH though.  The bar to MFH a port is pretty high; it has to be almost completely broken or have a security vulnerability.  Plus, this particular bug seems to have been introduced by 3.1.1, and that hasn't been MFHed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-05-24 20:37:50 UTC
A commit references this bug:

Author: asomers
Date: Sun May 24 20:37:20 UTC 2020
New revision: 536420
URL: https://svnweb.freebsd.org/changeset/ports/536420

Log:
  shells/fish: update to 3.1.2

  PR:		246681
  Submitted by:	dch

Changes:
  head/shells/fish/Makefile
  head/shells/fish/distinfo