Summary: | devel/simavr: fix build on GCC architectures | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | zirias | ||||
Priority: | --- | Flags: | zirias:
maintainer-feedback+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Piotr Kubaj
2020-05-25 09:07:24 UTC
Comment on attachment 214839 [details]
patch
Looks good (and also fixes a bug for any arch), thanks!
A commit references this bug: Author: pkubaj Date: Mon May 25 09:37:17 UTC 2020 New revision: 536451 URL: https://svnweb.freebsd.org/changeset/ports/536451 Log: devel/simavr: fix build on GCC architectures Merge the first hunk of https://github.com/buserror/simavr/commit/c2c8e40ff219f78779fc2743f0c1ffbabe159e37#diff-d06f1c6c1d6e380263f5450d5b70ca2b.diff to fix build. The whole patch can't be merged, the other two hunks don't apply. PR: 246719 Approved by: felix@palmen-it.de (maintainer) Changes: head/devel/simavr/files/patch-simavr_sim_run__avr.c $ simavr -m fffffffffffffffffffffff avr_make_mcu_by_name: AVR 'fffffffffffffffffffffff' not known simavr: AVR 'fffffffffffffffffffffff' not known $ simavr -m ffffffffffffffffffffffff [1] 6849 segmentation fault simavr -m ffffffffffffffffffffffff The patch should fix this, I'll test. If so, should probably bump portrevision. Yes, this segfault is fixed by the patch. Sorry for being late noticing this! |