Bug 246789
| Summary: | multimedia/ffmpeg: add the ability to apply any combination of SVT patches: SVTAV1, SVTHEVC and SVTVP9 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Vladimir Druzenko <vvd> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-multimedia (Nobody) <multimedia> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | cem, jbeich, multimedia, tcberner | ||||||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
vvd: maintainer-feedback? (jbeich) |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
I can't speak to the patch machinery, but I would really like to be able to enable SVTHEVC and SVTAV1 at the same time. Thank you for submitting the patch, VVD. 2 weeks left… Who can commit? Moin moin The whole thing looks a bit overly complicated to me. Could anyone elaborate why this is necessary, and we cannot have a simple, single patch for this? mfg Tobias (In reply to Tobias C. Berner from comment #3) Every SVT option depends on separate port: multimedia/svt-av1, multimedia/svt-hevc, multimedia/svt-vp9. The *patches* add options to the GNU autotools 'configure' script for each dependency. The plugins can be configured disabled if the corresponding port OPTION is disabled. I think this could be a simplified single patch, without removing OPTION flexibility. You would just always apply the patch, but add: SVTAV1_CONFIGURE_ENABLE= libsvtav1 SVTHEVC_CONFIGURE_ENABLE=libsvthevc SVTVP9_CONFIGURE_ENABLE= libsvtvp9 (*_CONFIGURE_ENABLE features are disabled if the port OPTION is disabled.) As the patches are directly from upstream, and not "processed" as I assumed previously, I can live with multiple patches :) But I would prefer to have them just always applied, without any need for the big if'fery that if that is possible. Created attachment 215424 [details]
Alternative patch
Did you said about this way?
(In reply to VVD from comment #8) Yes exactly! That looks way more maintainable to me. Created attachment 215520 [details]
Alternative patch
Fixed PATCH_SITES and upstream updated patches.
A commit references this bug: Author: tcberner Date: Sat Jun 13 17:14:48 UTC 2020 New revision: 538687 URL: https://svnweb.freebsd.org/changeset/ports/538687 Log: multimedia/ffmpeg: add the ability to have SVTAV1, SVTHEVC and SVTVP9 option on simultaneously - make it possible to have all three SVT options on simultaneously - always patch in support for all variants - use the patched in configure flag for feature toggling PR: 246789 Submitted by: VVD <vvd@unislabs.com> Changes: head/multimedia/ffmpeg/Makefile head/multimedia/ffmpeg/distinfo Committed. Thank you very much for both supplying the patches, and then working on them :) Thank you, VVD and Tobias! |
Created attachment 214935 [details] Add the ability to apply any combination of SVT patches: SVTAV1, SVTHEVC and SVTVP9 Tested on 12.1 amd64.