Bug 246791
| Summary: | sysutils/node_exporter: Update to v1.0.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | C <cm> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | dor.bsd, fernape, mikael, ports | ||||||
| Priority: | --- | Keywords: | needs-patch | ||||||
| Version: | Latest | Flags: | ports:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
C
2020-05-27 22:20:12 UTC
Asking for maintainer-feedback since it seems weird to approve this if the PR doesn't even have an attachment. Is the OP or the MAINTAINER willing to update one? I'm very sorry, I don't have the bandwidth to review this, or maintain this port. I need to put this port maintainership up for adoption. Hi, I can probably submit a patch to update this to 1.0 tomorrow, I'd be willing to take maintainership too. -David Excellent, thank you David. There's another related ticket that might interest you; https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246539 Yeah, that should be no problem. I've taken care of that in a few of the other exporters in the past :) Created attachment 215032 [details]
node_exporter: Update to 1.0.0
This patch updates sysutils/node_exporter to 1.0.0, it also takes care of the issue in #246539 and ensures that node_exporter is properly detached from the terminal.
The examples have been removed as they have been moved to another repository upstream.
I also take maintainership of the port in this patch.
I've noticed that there's an upstream bug in 1.0.0 which affects the node_exporter filesystem stats on FreeBSD, null bytes are being inserted into the time series labels. I'm currently trying to fix the issue and contribute the fix to upstream, it would be wise to hold off updating here for the time being. -David A PR to resolve the issue has been submitted upstream and should be merged before version 1.0.1 next week, at that point I'll update the diff in this issue with the new version. -David Apologies for the delay here, I haven't forgotten about this issue. The PR fixing filesystem stats on FreeBSD has been merged upstream, but there are a few more issues they wish to fix before releasing a new version. -David *** Bug 247120 has been marked as a duplicate of this bug. *** Version 1.0.1 has been published upstream earlier today, so I should have an updated patch here later tonight :) -David Created attachment 215626 [details] node_exporter: Update to 1.0.1 This patch updates node_exporter to version 1.0.1. In addition to the 1.0.0 changes, this release fixes: [BUGFIX] filesystem_freebsd: Fix label values [BUGFIX] Update prometheus/procfs to fix log noise [BUGFIX] Fix build tags for collectors [BUGFIX] Handle no data from powersupplyclass For a full changelog, see https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md -David (In reply to David O'Rourke from comment #12) it builds fine without gmake, why is it listed as a build dep? It looks like gmake was added as a dep by 0mp@ during some test additions, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234791. It's not directly commented on what it's for, but I assume `gmake test` is used to run the node_exporter tests after the pre-test target has run. -David thanks! A commit references this bug: Author: mikael Date: Wed Jun 17 16:05:59 UTC 2020 New revision: 539427 URL: https://svnweb.freebsd.org/changeset/ports/539427 Log: sysutils/node_exporter: update to 1.0.1 In addition to the 1.0.0 changes, this release fixes: [BUGFIX] filesystem_freebsd: Fix label values [BUGFIX] Update prometheus/procfs to fix log noise [BUGFIX] Fix build tags for collectors [BUGFIX] Handle no data from powersupplyclass For a full changelog, see https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md PR: 246791 Submitted by: David O'Rourke (maintainer) Changes: head/sysutils/node_exporter/Makefile head/sysutils/node_exporter/distinfo head/sysutils/node_exporter/files/node_exporter.in head/sysutils/node_exporter/pkg-message head/sysutils/node_exporter/pkg-plist |
