Bug 246854
| Summary: | net/pichi: Fix building failure on FreeBSD-13.0-CURRENT | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Pichi <pichi-router> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | fernape | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval Attachment -> Details -> maintainer-approval [+] Also, would you mind to recreate the patches so they comply with the preferred makepatch format? Thanks! (In reply to Fernando Apesteguía from comment #1) Could you please tell me how to create the patches who can comply with the preferred makepatch format? Thanks. (In reply to Pichi from comment #2) Sure, if you have a look at the output of portlint -AC: It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. So just run "make makepatch" and the framework will regenerate the patches and place them in files/ See https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html for details. Thanks! Created attachment 215952 [details]
net/pichi patch
Recreate the patch file for complying with makepatch format.
(In reply to Fernando Apesteguía from comment #3) Thanks a lot for your hints. Now, the new one has been uploaded. A commit references this bug: Author: fernape Date: Fri Jun 26 11:15:19 UTC 2020 New revision: 540491 URL: https://svnweb.freebsd.org/changeset/ports/540491 Log: net/pichi: Fix build on 13.0-CURRENT The default c++ compiler on FreeBSD 13.0 CURRENT is Clang10, which has more strict type checking than the one on FreeBSD 12. So, adding some patch files to fix it. PR: 246854 Submitted by: pichi@elude.in (maintainer) Changes: head/net/pichi/Makefile head/net/pichi/files/patch-include_pichi_config.hpp.in head/net/pichi/files/patch-server_main.cpp head/net/pichi/files/patch-test_endpoint.cpp head/net/pichi/files/patch-test_method.cpp head/net/pichi/files/patch-test_utils.hpp Committed, Thanks! |
Created attachment 215038 [details] net/pichi patch The default c++ compiler on FreeBSD 13.0 CURRENT is Clang10, which has more strict type checking than the one on FreeBSD 12. So, adding some patch files to fix it.