Summary: | net/liboping: Make error handling *BSD friendly (EHOSTDOWN) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> | ||||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | diizzy, gert, portmaster | ||||||
Priority: | --- | Keywords: | buildisok, needs-qa | ||||||
Version: | Latest | Flags: | portmaster:
maintainer-feedback+
koobs: merge-quarterly? |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151131600 ^Triage: - [tags] in issue Titles are deprecated - maintainer-feedback flag is only required if set to ? first @Maintainer Should this change be merged to the quarterly branch? (In reply to Kubilay Kocak from comment #3) Yes, please. :-) I'll try to keep all your thoughtful advise in mind on future pr(1)s. Thanks koobs! :-) --Chris Created attachment 215069 [details]
QA log for net/liboping
QA log for net/liboping to prove it builds/works
as intended -- no warns/errors.
--Chris
Can we please commit this? :-) Thanks. Perhaps bump it to latest release while at it? A commit references this bug: Author: amdmi3 Date: Fri Mar 19 23:01:01 UTC 2021 New revision: 568816 URL: https://svnweb.freebsd.org/changeset/ports/568816 Log: - Implement proper handling for EHOSTDOWN on FreeBSD [1] - While here, fix license, WWWs and silence stripping PR: 246855 Submitted by: portmaster@bsdforge.com (maintainer) Changes: head/net/liboping/Makefile head/net/liboping/files/ head/net/liboping/files/patch-src_liboping.c |
Created attachment 215039 [details] add BSD friendly error handler Error handling in liboping isn't really BSD agnostic. the patch attached to this pr(1) corrects that. It simply adds EHOSTDOWN to the list on ARP/ND failure. This addition was created by Gert Doering. Builds/runs as intended on 13.0-CURRENT r358902 amd64 CHANGES adds: files/patch-src_liboping.c That's it. Thanks! --Chris