Bug 246925

Summary: net/miniupnpd: Update to 2.1.20200510
Product: Ports & Packages Reporter: Tor Halvard Furulund <squat>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Open ---    
Severity: Affects Only Me CC: daniel.engberg.lists, ehaupt, fernape, lwhsu, squat
Priority: --- Keywords: buildisok
Version: LatestFlags: ehaupt: maintainer-feedback? (squat)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch against current ports.
squat: maintainer-approval+
Revised patch (see my comment) koobs: maintainer-approval? (squat)

Description Tor Halvard Furulund 2020-06-01 21:49:38 UTC
Created attachment 215150 [details]
Patch against current ports.

Update to latest upstream.
Remove the extra patches as they are incorporated upstream and change from EXTRA_PATCHES to CONFIGURE_ARGS for the PORT_OPTIONS.
Comment 1 Automation User 2020-06-01 22:07:01 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151755877
Comment 2 Emanuel Haupt freebsd_committer 2020-06-11 20:45:03 UTC
Thank you for your patch!

1. You've commented the IPF functionality:

+#if ${PORT_OPTIONS:MIPFW}
+#CONFIGURE_ARGS+= --firewall=ipfw
+#.endif

Was this intentional or can it be removed?

2. Same with AUTODETECT_FW. The option is defined but it does not seem to have a
handler.

3. Your patch indroduced a lot of unneccessary whitespaces. Try running
portlint -A (ports-mgmt/portlint) within the ports directory to catch those
errors.

4. Also, the OPTIONS handling can be simplified with OPTIONS helpers. See:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

5. I've created a patch to address most of the issues. Could you please apply it
and look into 1 and 2? Additionally I've run portfmt and portclippy
(ports-mgmt/portfmt) to address some indentation and formating issues.
Comment 3 Emanuel Haupt freebsd_committer 2020-06-11 20:47:12 UTC
Created attachment 215469 [details]
Revised patch (see my comment)
Comment 4 Li-Wen Hsu freebsd_committer 2020-08-13 09:53:26 UTC
(In reply to Tor Halvard Furulund from comment #0)
Please check and approve the patch in https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215469 , thanks!
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-13 12:30:28 UTC
^Triage: Reset to Open, cannot be in progress without a (real) assignee)
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-13 12:30:59 UTC
Comment on attachment 215469 [details]
Revised patch (see my comment)

^Triage: Request maintainer approval on attachments using the maintainer-approval attachment flag
Comment 7 daniel.engberg.lists 2020-12-12 07:19:48 UTC
2.2 is released as of 31/10/2020