Bug 246968

Summary: www/netsurf: Update to 3.10
Product: Ports & Packages Reporter: waitman
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Some People CC: fernape, waitman
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 246967    
Bug Blocks:    
Attachments:
Description Flags
www/netsurf port update to 3.10
none
www/netsurf port update to 3.10 (svn diff)
none
www/netsurf port update to 3.10 (svn diff) none

Description waitman 2020-06-04 02:00:06 UTC
Created attachment 215210 [details]
www/netsurf port update to 3.10

needs www/libdom update 0.4.1 (submitted bug)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-06-05 06:19:16 UTC
Hi there!

Thanks for the patch. Shar files are convenient when sending a new whole port but for updates svn diff is preferred.

Would you be able to upload a svn diff?

Thanks again :-)
Comment 2 waitman 2020-06-05 15:15:55 UTC
Created attachment 215253 [details]
www/netsurf port update to 3.10 (svn diff)
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-06-12 10:47:33 UTC
Hi there!

Thanks for the diff. Unfortunately, one of the patches does not apply. 

===>  Patching for netsurf-3.10
===>  Applying FreeBSD patches for netsurf-3.10 from /usr/ports/www/netsurf/files
1 out of 1 hunks failed--saving rejects to frontends/gtk/gui.c.rej
===>  FAILED Applying FreeBSD patch-frontends_gtk_gui.c
===> Cleanly applied FreeBSD patch(es)  patch-Makefile patch-frontends_gtk_Makefile.defaults
===> FAILED to apply cleanly FreeBSD patch(es)  patch-frontends_gtk_gui.c
*** Error code 1

Would you mind checking it?

Thanks!
Comment 4 waitman 2020-06-12 19:16:41 UTC
Sorry about that. That patch was removed because it was no longer needed due to upstream update. 

I believe I followed the instructions at https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-submitting.html

for creating svn diff, but it looks like it didn't "Remove" the file from files/
Comment 5 waitman 2020-06-12 19:42:41 UTC
Created attachment 215493 [details]
www/netsurf port update to 3.10 (svn diff)

remove files/patch-frontends_gtk_gui.c

originally upstream hardcoded path to ssl certs. however, this was fixed upstream so the patch is no longer needed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-06-16 11:59:07 UTC
A commit references this bug:

Author: fernape
Date: Tue Jun 16 11:58:45 UTC 2020
New revision: 539343
URL: https://svnweb.freebsd.org/changeset/ports/539343

Log:
  www/netsurf: Update to 3.10

  PR:	246968
  Submitted by:	waitman@waitman.net

Changes:
  head/www/netsurf/Makefile
  head/www/netsurf/distinfo
  head/www/netsurf/files/patch-Makefile
  head/www/netsurf/files/patch-frontends_gtk_gui.c
  head/www/netsurf/files/patch-utils_idna.c
  head/www/netsurf/pkg-plist
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2020-06-16 11:59:37 UTC
Committed, sorry for the delay

Thanks!