Bug 246981

Summary: ports-mgmt/pkg plugins: configuration settings not provided due to missing object allocation
Product: Ports & Packages Reporter: Markus Stoff <markus>
Component: Ports FrameworkAssignee: freebsd-pkg (Nobody) <pkg>
Status: Closed FIXED    
Severity: Affects Only Me CC: markus, pkg, ports-bugs
Priority: --- Flags: linimon: maintainer-feedback? (pkg)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Suggested fix for libpkg/plugins.c and updated examples
none
Suggested fix for libpkg/plugins.c
none
Updated examples in pkg-plugins repository
none
Updated examples in pkg-plugins repository none

Description Markus Stoff 2020-06-04 13:35:18 UTC
Created attachment 215227 [details]
Suggested fix for libpkg/plugins.c and updated examples

Due to a missing allocation of the UCL base object the configuration is parsed but not provided to the plugin.

See 'pkg.diff' in the attached archive for a suggested fix of libpkg/plugins.c.

Also the examples in the 'pkg-plugins' repository are severely outdated. Please see the other diff on some improvements, notably of the template and the zfssnap plugins.
Comment 1 Markus Stoff 2020-06-04 13:36:47 UTC
Created attachment 215228 [details]
Suggested fix for libpkg/plugins.c
Comment 2 Markus Stoff 2020-06-04 13:38:26 UTC
Created attachment 215229 [details]
Updated examples in pkg-plugins repository

Diff is based on github repo at https://github.com/freebsd/pkg-plugins/
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2020-06-05 07:17:25 UTC
Fix up assignment.

fwiw Ports Infrastructure is, and only is, about the *.FreeBSD.org package building machines.
Comment 4 Markus Stoff 2020-06-05 08:21:46 UTC
Created attachment 215243 [details]
Updated examples in pkg-plugins repository

Based on: https://github.com/freebsd/pkg-plugins/