Bug 246987
| Summary: | sysutils/dvdisaster: Fix build error with gcc10 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bob Eager <bob> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | fernape, gerald, linimon | ||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 246700, 246957 | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: gerald Date: Fri Jun 12 21:30:45 UTC 2020 New revision: 538632 URL: https://svnweb.freebsd.org/changeset/ports/538632 Log: Fix the build with GCC 10 that defaults to -fno-common via a new local patch files/patch-dvdisaster.h. PR: 246700, 246957, 246987 Submitted by: bob@eager.cx (maintainer) Changes: head/sysutils/dvdisaster/files/patch-dvdisaster.h Thank you for the super quick response, Bob! I committed your patch, just omitted two aspects: - The PORTREVISION bump, since we do not need to do that for build fixes. (Where it built before, the result should not change; if it did not, there is no previous package). - The "empty" patch for another file. (To reduce churn in the repo.) |
Created attachment 215232 [details] Diffs for port files Fails to build with gcc10 due to misuse of/missing extern. Patch attached. NEW FILE: files/patch-dvdisaster.h Tested on 12.1-RELEASE-p5 (amd64) and on 13-CURRENT (amd64). PR 246957 refers.