Bug 247071

Summary: lang/crystal: update to 0.34.0 (& devel/shards 0.11.0)
Product: Ports & Packages Reporter: Val Packett <val>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: cs, fernape, mikael
Priority: --- Keywords: easy, patch
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://reviews.freebsd.org/D25191
Attachments:
Description Flags
crystal0340.patch val: maintainer-approval+

Description Val Packett 2020-06-07 21:28:46 UTC
Created attachment 215343 [details]
crystal0340.patch

amazingly, no bootstrap update required for two whole versions
Comment 1 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2020-06-08 05:40:57 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 2 Val Packett 2020-06-08 10:33:02 UTC
Comment on attachment 215343 [details]
crystal0340.patch

huh, this is the first time anyone asked me to do that..
Comment 3 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2020-06-08 11:11:54 UTC
(In reply to Greg V from comment #2)

Many people forget or are just not aware of this. It's not a big deal really although it helps keeping the PR database tight :-)

Thanks!
Comment 4 Carlo Strub freebsd_committer freebsd_triage 2020-06-08 20:10:56 UTC
I cannot apply your patch. There is a rejection in Makefile. Can you please recreate it.
Comment 5 Val Packett 2020-06-08 20:45:47 UTC
(In reply to Carlo Strub from comment #4)

What is the rejection exactly? I'm not sure recreating would help.
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2020-06-11 17:42:40 UTC
(In reply to Carlo Strub from comment #4)
svn patch --strip 1 or patch -p1
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-06-13 08:42:22 UTC
A commit references this bug:

Author: mikael
Date: Sat Jun 13 08:42:07 UTC 2020
New revision: 538654
URL: https://svnweb.freebsd.org/changeset/ports/538654

Log:
  lang/crystal: update to 0.34.0 (& devel/shards 0.11.0)

  PR:		247071
  Submitted by:	Greg V (maintainer)

Changes:
  head/devel/shards/Makefile
  head/devel/shards/distinfo
  head/lang/crystal/Makefile
  head/lang/crystal/distinfo
  head/lang/crystal/pkg-plist
Comment 8 Mikael Urankar freebsd_committer freebsd_triage 2020-06-13 08:42:52 UTC
Thanks!