Bug 247107

Summary: irc/srain: Fails to build with base OpenSSL due to base not providing pkg-config
Product: Ports & Packages Reporter: Thibault Payet <monwarez>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Some People Keywords: needs-qa
Priority: --- Flags: ashish: maintainer-feedback+
ashish: merge-quarterly-
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to build against base openssl none

Description Thibault Payet 2020-06-09 11:57:05 UTC
Created attachment 215390 [details]
patch to build against base openssl

Hi, when trying to build the port, it does not find openssl with pkg-config (when using ssl from base, pkg-config cannot find it). The patch that I have done consist of using the variable available from the port framework when having ssl in the USES macro.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-10 03:28:58 UTC
Patch should be QA'd against all other values of DEFAULT_VERSIONS for ssl as well
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2020-06-10 22:15:24 UTC
Sorry about this. I missed that part. :(

I will come up with a fix.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-11 01:43:25 UTC
A commit references this bug:

Author: ashish
Date: Thu Jun 11 01:43:10 UTC 2020
New revision: 538450
URL: https://svnweb.freebsd.org/changeset/ports/538450

Log:
  - Fix building with OpenSSL base which does not provide pkgconfig
    configuration

  PR:		247107
  Submitted by:	Thibault Payet <monwarez at mailoo.org>

Changes:
  head/irc/srain/files/patch-src_Makefile
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2020-06-11 01:47:27 UTC
Sorry for the issue. Thanks for the diff. It's committed now.

w.r.t. merge-quarterly flag, it's not required as this port is not present in 2020Q2 branch.

Thanks!