Bug 247109

Summary: www/node10: building node10-10.20.1_1 was failed due to absence of option "--openssl-no-asm"
Product: Ports & Packages Reporter: Hiroyuki Une <une>
Component: Individual Port(s)Assignee: Bradley T. Hughes <bhughes>
Status: Closed FIXED    
Severity: Affects Many People Flags: bhughes: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Build log of node10-10.20.1_1 none

Description Hiroyuki Une 2020-06-09 12:47:24 UTC 
Created attachment 215391 [details]
Build log of node10-10.20.1_1

When I built editors/vscode by pourdriere on my 11-stable (r361070) box, 
node10-1.20.1_1 build process was failured with the following message: 

=== begin error messages

=======================<phase: configure      >============================
===>  Configuring for node10-10.20.1_1
ERROR: Did not find a new enough assembler, install one or build with
       --openssl-no-asm.
       Please refer to BUILDING.md
===>  Script "configure" failed unexpectedly.
Please report the problem to bhughes@FreeBSD.org [maintainer] and attach the
"/wrkdirs/usr/ports/www/node10/work/node-v10.20.1/config.log" including the
output of the failure of your make command. Also, it might be a good idea to
provide an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/www/node10
=>> Cleaning up wrkdir
===>  Cleaning for node10-10.20.1_1
build of www/node10 | node10-10.20.1_1 ended at Tue Jun  9 21:19:38 JST 2020
build time: 00:00:38
!!! build failure encountered !!!

=== end error messages

Unfortunately, I couldn't get config.log because poudriere remove it.  
I would appreciate if someone gives any suggestion.
Comment 1 Bradley T. Hughes freebsd_committer freebsd_triage 2020-06-09 19:28:42 UTC 
I have also run into this error when trying to build www/node10 on 11.4-RC2. The problem is with how the Node.js 10.x configure.py script detects the LLVM version; it doesn't work for the latest LLVM 10.x. I am currently testing a fix, which I will commit shortly. :)
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-06-09 20:45:56 UTC 
A commit references this bug:

Author: bhughes
Date: Tue Jun  9 20:45:12 UTC 2020
New revision: 538343
URL: https://svnweb.freebsd.org/changeset/ports/538343

Log:
  www/node10: fix build with LLVM 10.x and BUNDLED_SSL

  Add patch-configure.py to fix the LLVM version detection, which did not
  work with LLVM 10.x. Add patch-common.gypi to remove the LLVM <4
  detection that would add -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 to CFLAGS;
  this is no longer needed.

  Bump PORTREVISION since the installed include/node/common.gypi has
  changed.

  PR:		247109
  Reported by:	Hiroyuki Une <une@edu.hkg.ac.jp>
  Sponsored by:	Miles AS

Changes:
  head/www/node10/Makefile
  head/www/node10/files/patch-common.gypi
  head/www/node10/files/patch-configure.py
Comment 3 Hiroyuki Une 2020-06-10 00:01:30 UTC 
(In reply to commit-hook from comment #2)
I confirmed that it works.  Thank you.
Comment 4 Bradley T. Hughes freebsd_committer freebsd_triage 2020-06-10 04:35:14 UTC 
You're welcome, and thanks for the report :)