Bug 247185
| Summary: | irc/irssi: fix utf8proc support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Pankov <yuripv> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | dor.bsd, fernape | ||||||
| Priority: | --- | Flags: | dor.bsd:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
^Triage: Reporter is committer, assign accordingly. (In reply to Fernando Apesteguía from comment #1) Hi Fernando, I'm not a ports committer, and not entirely sure the patch is correct (even if it seems to DTRT), so I'd like ports-aware committer to take care of this if/when maintainer approves. (In reply to Yuri Pankov from comment #2) Hi Yuri! Committers without a ports bit may obtain review by any ports committer and are then free to commit once accepted. This can be done via Phabricator or requesting review on freebsd-ports (or any other collaboration channels you/we use) I agree we should wait (at least one week) to hear from maintainer Comment on attachment 215470 [details]
fix utf8proc support
Looked good to me after a run through poudriere, thanks for catching this :)
-David
Created attachment 215522 [details]
additional improvements on top of submitter's patch
I made a change to the original patch: USES=localbase instead of adding the path manually:
===> irssi-1.2.2_1,1 depends on shared library: libutf8proc.so - found (/usr/local/lib/libutf8proc.so)
While here, since this port installs libraries, add USE_LDCONFIG.
Also remove the post-patch block since it doesn't actually change anything in the manpage (no traces of /usr or /etc in it).
Finally bump PORTREVISION.
This builds in {11.3,12.1}{amd64,i386} and 13-current amd64, but I did not run-test it.
Will you, please?
Comment on attachment 215522 [details]
additional improvements on top of submitter's patch
The addition of localbase looks good. This change and the utf8proc change both run well locally after both a /upgrade and running a fresh instance of irssi.
-David
A commit references this bug: Author: fernape Date: Mon Jun 15 10:41:56 UTC 2020 New revision: 538869 URL: https://svnweb.freebsd.org/changeset/ports/538869 Log: irc/irssi: fix utf8proc support Port was not using utf8proc since it didn't look for it in localbase. While here: * Add USE_LDCONFIG * Remove post-patch target since it has no effect PR: 247185 Submitted by: yuripv@ Reviewed by: dor.bsd@xm0.uk (maintainer) Changes: head/irc/irssi/Makefile Committed, Thank you both! |
Created attachment 215470 [details] fix utf8proc support Currently irc/irssi fails to detect utf8proc even if it's installed, provide needed CPPFLAGS/LDFLAGS. Also, if option is off, we need to explicitly disable utf8proc support to properly record dependencies. $ make showconfig ===> The following configuration options are available for irssi-1.2.2,1: BOT=off: Bot support CAPSICUM=on: Capsicum support DOCS=on: Build and/or install documentation OTR=off: OTR (off-the-record) support PERL=on: Perl scripting language support PROXY=off: Proxy support SOCKS=off: Socks proxy support TRUECOLOR=on: Truecolor (24bit) support UTF8PROC=on: utf8proc support ===> Use 'make config' to modify these settings $ make configure 2>&1 | grep utf8proc ===> irssi-1.2.2,1 depends on shared library: libutf8proc.so - found (/usr/local/lib/libutf8proc.so) checking utf8proc.h usability... no checking utf8proc.h presence... no checking for utf8proc.h... no Building with utf8proc ........... : no, library header not found