Bug 247244
| Summary: | [NEW PORT] security/vigenere: Vigenere cipher cryptography tool | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oliver Mahmoudi <contact> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | fernape | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi Oliver,
Thanks for the submission.
The first line:
# $FreeBSD$
is missing.
After adding that, please check portlint -AC (there are a number of minor issues).
Also WRKSRC already defaults to ${WRKDIR}/${PORTNAME}-${PORTVERSION} and can be remove.
Would you make the changes?
Also, Any chances of using the original Makefile to build and install de port instead of replicating the same logic in the port's Makefile? Hi Fernando,
I made the following changes to the port:
1. Added the "# $FreeBSD$" header.
2. Deleted a few whitespaces.
Now portlint no longer complains :)
Regarding using the original Makefile, I thought about that too, however,
there are a few issues related to that:
1. The Makefile uses gmake, which would require another dependency to be
pulled into the port.
2. FreeBSD's C compiler defaults to clang in these days, the Makefile assumes
gcc.
3. It is just a bare bones Makefile, that doesn't honour ${PREFIX} being set
to something other than /usr/local.
In other words, the original Makefile doesn't work right out of the box and
would have to be rewritten, more or less entirely. For these reasons, I think
that, building the port with the rules specified in the port's trunk is a whole
lot more efficient.
You'll find the updated port in the attachments.
Thanks!
Created attachment 215677 [details]
updated shar archive for security/vigenere
A commit references this bug: Author: fernape Date: Thu Jun 18 06:57:45 UTC 2020 New revision: 539531 URL: https://svnweb.freebsd.org/changeset/ports/539531 Log: new port: security/vigenere: cipher algorithm tool vigenere is an implementation of the Vigenere cipher algorithm extended to the entire set of printable ASCII characters https://www.olivermahmoudi.com/programming/vigenere-cipher/ PR: 247244 Submitted by: fbsd@olivermahmoudi.com Changes: head/security/Makefile head/security/vigenere/ head/security/vigenere/Makefile head/security/vigenere/distinfo head/security/vigenere/pkg-descr Committed, Thanks! |
Created attachment 215532 [details] shar file for new port: security/vigenere New port security/vigenere is an implementation of the Vigenere cipher encryption algorithm with an extension to all printable ASCII characters.