Bug 247299
| Summary: | mail/gmime30: Add VALA option | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bertram Scharpf <software> | ||||||||
| Component: | Individual Port(s) | Assignee: | Gleb Popov <arrowd> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | arrowd, gnome, lantw44 | ||||||||
| Priority: | --- | Keywords: | feature | ||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(gnome) |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 248509 | ||||||||||
| Attachments: |
|
||||||||||
Thank you for the report and patch Bertram.
The .if ${PORT_OPTIONS:MVALA} block should be converted to the options helper syntax
VALA_BUILD_DEPENDS=
VALA_CONFIGURE_OFF
But I would also try just:
VALA_BUILD_DEPENDS=foo
VALA_CONFIGURE_ENABLE=vala (configure needs to support --disable-vala, which some dont)
Created attachment 215745 [details]
Patch with options helper syntax
Does this new patch please you more?
I just copied it from +mail/gmime26+ and wonder why this was removed in version 30.
(In reply to Bertram Scharpf from comment #2) Can you keep vala enabled by default, so the existing behavior isn't changed? Created attachment 215967 [details]
Gmime30 patch with vala option and vala default
Next try...
Reminder. Reminder. Last reminder. The next will be another bug report about the bug report system. A commit references this bug: Author: arrowd Date: Fri Aug 7 11:45:50 UTC 2020 New revision: 544324 URL: https://svnweb.freebsd.org/changeset/ports/544324 Log: mail/gmime30: Introduce VALA option to make it possible to disable vala bindings. PR: 247299 Submitted by: Bertram Scharpf <software@bertram-scharpf.de> Reviewed by: koobs Approved by: gnome (maintainer timeout) Changes: head/mail/gmime30/Makefile head/mail/gmime30/pkg-plist Thank you for your contribution. ^Triage: Assign to committer that resolved |
Created attachment 215602 [details] Patch with vala option On a non-graphic system I have installed +neomutt+. This pulls +gmime30+ what now tries to install +vala+. I do not want this. I propose an option to deactivate the Vala lib bindings. I tested my patch on the non-graphical system and on a graphical one as well.