Bug 247425

Summary:	fstyp and makefs tests fail after UFS superblock format changes
Product:	Base System	Reporter:	Li-Wen Hsu <lwhsu>
Component:	tests	Assignee:	freebsd-fs (Nobody) <fs>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	cem, emaste, mckusick
Priority:	---
Version:	CURRENT
Hardware:	Any
OS:	Any

Description Li-Wen Hsu freebsd_committer

2020-06-19 15:28:37 UTC

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15572/ includes r362358 and r362359, 9 fstyp and makefs tests failed:

    usr.sbin.fstyp.fstyp_test.ufs1
    usr.sbin.fstyp.fstyp_test.ufs2
    usr.sbin.fstyp.fstyp_test.ufs2_label
    usr.sbin.makefs.makefs_ffs_tests.F_flag
    usr.sbin.makefs.makefs_ffs_tests.from_mtree_spec_file
    usr.sbin.makefs.makefs_ffs_tests.from_multiple_dirs
    usr.sbin.makefs.makefs_ffs_tests.from_single_dir
    usr.sbin.makefs.makefs_ffs_tests.o_flag_version_1
    usr.sbin.makefs.makefs_ffs_tests.o_flag_version_2

I haven't checked if these tests need updated or fstyp(8) and makefs(8) need fixing.

Comment 1 commit-hook freebsd_committer

2020-06-19 17:33:12 UTC

A commit references this bug:

Author: lwhsu
Date: Fri Jun 19 17:32:30 UTC 2020
New revision: 362390
URL: https://svnweb.freebsd.org/changeset/base/362390

Log:
  Skip ufs related tests in fstyp(8) and makefs(8) temporarily

  They are failing after r362358 and r362359.

  PR:		247425
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/usr.sbin/fstyp/tests/fstyp_test.sh
  head/usr.sbin/makefs/tests/makefs_ffs_tests.sh

Comment 2 commit-hook freebsd_committer

2020-06-19 23:33:25 UTC

A commit references this bug:

Author: mckusick
Date: Fri Jun 19 23:32:40 UTC 2020
New revision: 362418
URL: https://svnweb.freebsd.org/changeset/base/362418

Log:
  Allocate an fs_summary_info structure when creating a UFS filesystem
  needed since introduced in -r362358.

  PR:           247425
  Sponsored by: Netflix

Changes:
  head/usr.sbin/makefs/ffs/mkfs.c

Comment 3 commit-hook freebsd_committer

2020-06-23 19:15:25 UTC

A commit references this bug:

Author: lwhsu
Date: Tue Jun 23 19:14:39 UTC 2020
New revision: 362551
URL: https://svnweb.freebsd.org/changeset/base/362551

Log:
  Revert r362390, those tests are fixed by r362418

  PR:		247425
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/usr.sbin/fstyp/tests/fstyp_test.sh
  head/usr.sbin/makefs/tests/makefs_ffs_tests.sh

Comment 4 commit-hook freebsd_committer

2020-06-23 21:28:48 UTC

A commit references this bug:

Author: mckusick
Date: Tue Jun 23 21:28:27 UTC 2020
New revision: 362559
URL: https://svnweb.freebsd.org/changeset/base/362559

Log:
  The libufs library needs to track and free the new fs_si structure
  in addition to the fs_csp structure that it references.

  PR:           247425
  Sponsored by: Netflix

Changes:
  head/lib/libufs/libufs.h
  head/lib/libufs/sblock.c
  head/lib/libufs/type.c
  head/sbin/fsck_ffs/setup.c

Comment 5 commit-hook freebsd_committer

2020-06-23 21:37:51 UTC

A commit references this bug:

Author: mckusick
Date: Tue Jun 23 21:37:13 UTC 2020
New revision: 362560
URL: https://svnweb.freebsd.org/changeset/base/362560

Log:
  Correctly describe the return values for the libufs library sbget()
  and sbput() functions that respectively read and write the superblock.

  PR:           247425
  Sponsored by: Netflix

Changes:
  head/lib/libufs/sbread.3

Comment 6 commit-hook freebsd_committer

2020-06-23 21:44:53 UTC

A commit references this bug:

Author: mckusick
Date: Tue Jun 23 21:44:00 UTC 2020
New revision: 362561
URL: https://svnweb.freebsd.org/changeset/base/362561

Log:
  Optimize g_journal's superblock update by noting that the summary
  information is neither read nor written so it need not be written
  out when updating the superblock.

  PR:           247425
  Sponsored by: Netflix

Changes:
  head/sys/geom/journal/g_journal_ufs.c

Comment 7 Kirk McKusick freebsd_committer

2020-06-23 22:01:03 UTC

The above four commit messages should have been posted to bug 246983.
Sorry for the confusion.