Bug 247448

Summary: ports-mgmt/poudriere: Fix jail -d -C
Product: Ports & Packages Reporter: Anton Saietskii <vsasjason>
Component: Individual Port(s)Assignee: Bryan Drewery <bdrewery>
Status: Open ---    
Severity: Affects Some People CC: tatsuki_makino
Priority: --- Keywords: buildisok, needs-qa
Version: LatestFlags: vsasjason: maintainer-feedback-
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
See Also: https://github.com/freebsd/poudriere/pull/532
Attachments:
Description Flags
fix -C option
none
fix -C option (full patch) none

Description Anton Saietskii 2020-06-20 21:50:57 UTC 
Created attachment 215830 [details]
fix -C option

This have been implemented in https://github.com/freebsd/poudriere/pull/532, but one of the commits (https://github.com/freebsd/poudriere/pull/532/commits/33d6823387fc20480ff251adcc0bf7f3303c7ea8) was incorrect, and CLEANJAIL variable always equals 0.
Mentioned commit changed CLEAN to CLEANJAIL in lines -1021,+1016, but -1079,+1074 done incorrectly:

CLEAN=${CLEAN:-none}
CLEANJAIL=${CLEAN:-none}

Second should be:
CLEANJAIL=${CLEANJAIL:-none}
Or even better:
: "${CLEANJAIL:=none}"

I don't have a GitHub account, so attached patch that fixes ports tree itself.
Comment 1 Anton Saietskii 2020-06-20 21:54:15 UTC 
Created attachment 215831 [details]
fix -C option (full patch)
Comment 2 Automation User 2020-07-06 00:09:53 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/163313309
Comment 3 Anton Saietskii 2021-01-05 14:19:44 UTC 
Any updates on this?
Comment 4 Tatsuki Makino 2021-12-24 05:21:38 UTC 
I don't think that fix will affect the behavior much.
But I think this -C option is broken :)
(poudriere-3.3.7_1)

For example, poudriere -d -j pkg -C all
Comment 5 Anton Saietskii 2022-06-02 15:24:32 UTC 
(In reply to Tatsuki Makino from comment #4)
> I don't think that fix will affect the behavior much.
But I verified and it worked exactly as expected after applying patch.
Comment 6 Anton Saietskii 2022-06-10 08:44:37 UTC 
Could somebody please take a look? I'm afraid that 2 years for such a simple report is a "bit" too much.