Bug 247509

Summary: x11-themes/slim-freebsd-dark-theme: Update pkg-descr
Product: Ports & Packages Reporter: Miguel Gocobachi <miguel>
Component: Individual Port(s)Assignee: Mateusz Piotrowski <0mp>
Status: Closed FIXED    
Severity: Affects Some People CC: 0mp, miguel
Priority: --- Flags: miguel: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update diff
none
diff update and using INSTALL_DATA instead none

Description Miguel Gocobachi 2020-06-23 19:33:29 UTC
Created attachment 215891 [details]
update diff

This ticket is for updating the pkg-descr content, as per suggestion from bapt@ and 0mp@.
Comment 1 Bugzilla Automation freebsd_committer 2020-06-23 19:33:29 UTC
Maintainer informed via mail
Comment 2 Mateusz Piotrowski freebsd_committer 2020-06-23 19:45:54 UTC
Hint: if you are a maintainer, you may want to set "maintainer-feedback" to "+" in *Flags * field on Bugzilla. This way its clear that the maintainer is fine with the patch.

BTW, would you like to incorporate the other change suggested in the email? I.e., replacing COPYTREE_SHARE with long the lines of "${INSTALL_DATA} *.png *.theme ${STAGEDIR}${_THEMEDIR}".

Cheers! :)
Comment 3 Miguel Gocobachi 2020-06-23 22:36:18 UTC
Created attachment 215897 [details]
diff update and using INSTALL_DATA instead

is this how you suggest? "make stage" works fine.
Comment 4 commit-hook freebsd_committer 2020-06-25 15:55:36 UTC
A commit references this bug:

Author: 0mp
Date: Thu Jun 25 15:54:55 UTC 2020
New revision: 540399
URL: https://svnweb.freebsd.org/changeset/ports/540399

Log:
  Simplify do-install and improve pkg-descr

  PR:		247509
  Submitted by:	Miguel Gocobachi <miguel@gocobachi.dev>
  Suggested by:	bapt

Changes:
  head/x11-themes/slim-freebsd-dark-theme/Makefile
  head/x11-themes/slim-freebsd-dark-theme/pkg-descr