Summary: | print/xfce4-print: compiler error: incomplete definition of type 'struct _ipp_attribute_s' | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | O. Hartmann <ohartmann> |
Component: | Individual Port(s) | Assignee: | freebsd-xfce (Nobody) <xfce> |
Status: | Closed Not Accepted | ||
Severity: | Affects Only Me | CC: | madpilot |
Priority: | --- | Flags: | madpilot:
maintainer-feedback+
|
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
O. Hartmann
2020-06-27 09:57:55 UTC
Hi, The xfce4-print port (together with others, like xfce4-mixer) has been dropped and is not being developed anymore. It is in the ports tree, but bit rot is quickly getting in. In this case you are compiling with the CUPS option (off by default), and it appears that recent changes in the cups include files caused cups support in xfce4-print to break. The upstream commit in cups causing this can be viewed at [1] xfce4-print was accessing cups private structures. We already had a patch in out tree adding a define which allowed the include file to expose these deprecated structures. Such flag has been removed by the upstream, causing the breakage you see. I'm sorry, but short of a rewrite of all the relevant code in xfce4-print this cannot be fixed, but with no upstream this is improbable. Also note that xfce4-print, also depends on GTK2. XFCE development versions have already removed all support for GTK2, so any xfce component depending on GTK2 needs to be ported to GTK3 or will fail to compile with the future release of XFCE 4.16. Obviously for components whose support has been dropped long ago by upstream such porting to GTK3 is very improbable. xfce4-print, xfce4-mixer, xfce4-quicklauncher-plugin are some popular XFCE ports that WILL be removed from the tree when XFCE will be updated to 4.16,m and risk breaking irreparably before that due to bit rot (no upstream development). Some other xfce parts have not been ported to GTK3 up to now, but are actively supported, and I expect them to be ported by the time 4.16 beta versions will be around. I'm sorry but unless someone with cups development knowledge comes up with patches, I can only remove the CUPS option from the port since it's broken. I'll also take this as a chance to mark all the xfce ports which are not being supported upstream and still depending on gtk2 as DEPRECATED in our tree to let it known that they could be removed at any time if any non trivial breakage happens. Leaving the bug in open state for now, at least until I commit the change described above. [1] https://github.com/apple/cups/commit/0fb02fb9cef39fd0b0c838f11af21d99fe5eab9b#diff-a299fb5293cedc8102f5963e50fbe22c All right, thanks for the care. A commit references this bug: Author: madpilot Date: Sat Jun 27 14:55:18 UTC 2020 New revision: 540612 URL: https://svnweb.freebsd.org/changeset/ports/540612 Log: Remove CUPS option. It's not working anymore since the cups update to 2.3.3. The port was already using a deprecated interface exposing cups internal structures. Support for this has been recently removed upstream. PR: 247580 Submitted by: O. Hartmann <ohartmann@walstatt.org> Changes: head/print/xfce4-print/Makefile head/print/xfce4-print/files/ Closing, since I'm unable to fix the reported issue. The broken option has been removed and this ports together with other ports in a similar situation have been marked DEPRECATED, but without an EXPIRATION_DATE. |