Bug 247684

Summary: sysutils/py-bitrot: fix pkg-fallout errors
Product: Ports & Packages Reporter: Darren Mulligan <fixer>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape
Priority: --- Keywords: buildisok
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
require python 3.5
fixer: maintainer-approval+
require python 3.5+ fixer: maintainer-approval+

Description Darren Mulligan 2020-07-01 06:43:57 UTC
Created attachment 216101 [details]
require python 3.5

the latest update of this port cannot be used with python 2.7, so require 3.5 at least to fix pkg-fallout errors. tested with 3.5, 3.6, 3.7, 3.8.
Comment 1 Automation User 2020-07-01 06:52:03 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/161875742
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2020-07-01 07:57:36 UTC
Hi Darren,

Thanks for the patch. There is an issue here:

RUN_DEPENDS:=  ${BUILD_DEPENDS}

See https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html to know why this is a bad idea (both assigning BUILD_ to RUN and the use of operator := )

Cheers!
Comment 3 Darren Mulligan 2020-07-01 08:05:12 UTC
Created attachment 216106 [details]
require python 3.5+

Remove unrelated (and incorrectly done) run depends change.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-07-01 15:24:22 UTC
A commit references this bug:

Author: fernape
Date: Wed Jul  1 15:24:08 UTC 2020
New revision: 540970
URL: https://svnweb.freebsd.org/changeset/ports/540970

Log:
  sysutils/py-bitrot: fix pkg-fallout errors

  Latest update to the port requires at least python 3.5

  PR:	247684
  Submitted by:	fixer@bsdmail.com (maintainer)

Changes:
  head/sysutils/py-bitrot/Makefile
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2020-07-01 15:24:58 UTC
Committed,

Thanks!