Summary: | devel/pcsc-lite: set ipcdir to /var/run again | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Christoph Moench-Tegeder <cmt> | ||||
Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | diizzy, lwhsu, tatsuki_makino | ||||
Priority: | --- | Keywords: | easy, patch, patch-ready | ||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(mmokhi) cmt: merge-quarterly? |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Christoph Moench-Tegeder
2020-07-02 15:58:53 UTC
I'll take care of this because of I committed ports r540943. A commit references this bug: Author: lwhsu Date: Thu Jul 2 17:05:44 UTC 2020 New revision: 541046 URL: https://svnweb.freebsd.org/changeset/ports/541046 Log: Restore ipcdir to /var/run PR: 247719 [1] 247286 [2] Submitted by: cmt [1] Reported by: Tatsuki Makino [2] Approved by: maintainer timeout (followup last coomit) MFH: 2020Q3 Changes: head/devel/pcsc-lite/Makefile Thank you. It works for me, too. However, that's a minor change from 1.8.24. The location of pcscd.comm and pcscd.pid changes from /var/run/pcscd to /var/run. The reason for that is the following fragment of unified diff. --- pcsc-lite-1.8.24/configure.ac 2018-10-12 09:06:13.000000000 +0000 +++ pcsc-lite-1.9.0/configure.ac 2020-06-14 13:27:22.000000000 +0000 @@ -365,13 +371,13 @@ # --enable-ipcdir=DIR AC_ARG_ENABLE(ipcdir, AS_HELP_STRING([--enable-ipcdir=DIR],[directory containing IPC files - (default /var/run/pcscd)]), + (default /run/pcscd)]), [ipcdir="${enableval}"], [ipcdir=false]) if test x${ipcdir} = xfalse ; then - ipcdir="/var/run/pcscd" + ipcdir="/run/pcscd" fi AC_DEFINE_UNQUOTED(USE_IPCDIR, "$ipcdir", [directory containing IPC files]) PCSCLITE_FEATURES="${PCSCLITE_FEATURES} ipcdir=${ipcdir}" (In reply to Tatsuki Makino from comment #3) Should we also restore this behavior? (In reply to Li-Wen Hsu from comment #4) ah yes, that makes sense. sorry for the thinko - handling too much stuff at once (In reply to Li-Wen Hsu from comment #4) (In reply to Christoph Moench-Tegeder from comment #5) I don't know what the change from /var/run/pcscd/pcscd.{comm,pid} to /var/run/pcscd.{comm,pid} will affect :) A commit references this bug: Author: lwhsu Date: Sat Jul 4 09:24:20 UTC 2020 New revision: 541181 URL: https://svnweb.freebsd.org/changeset/ports/541181 Log: MFH: r541046 Restore ipcdir to /var/run PR: 247719 [1] 247286 [2] Submitted by: cmt [1] Reported by: Tatsuki Makino [2] Approved by: maintainer timeout (followup last coomit) Approved by: ports-secteam (joneum) Changes: _U branches/2020Q3/ branches/2020Q3/devel/pcsc-lite/Makefile fixed 4 months ago - as the submitter I'm cleaning up this old PR |