Summary: | www/chromium: crash when U2F is used | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Henry Hu <henry.hu.sh> | ||||
Component: | Individual Port(s) | Assignee: | Oleksandr Tymoshenko <gonzo> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | chromium, delphij, gonzo, jrm, robert.ayrapetyan | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(chromium) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Henry Hu
2020-07-03 17:09:54 UTC
+gonzo@ I'll take a look Created attachment 216649 [details]
fix-chromium-hid-service.patch
This patch fixes the crash and make U2F functional. There is an issue
with repeated access: if you try to perform two operations in row the
second one fails. Re-try then succeeds. I'm not sure if it's a new
problem or pre-existing issue with FreeBSD's HID implementation and
will take look later.
Adding chromium@freebsd.org. Can port committers on that list take a look at the patch and commit it? I don't have ports commit bit. Same issue, patch works, thanks! A commit references this bug: Author: jrm Date: Sat Aug 15 20:55:07 UTC 2020 New revision: 545068 URL: https://svnweb.freebsd.org/changeset/ports/545068 Log: www/chromium: Fix U2F authentication PR: 247744 Submitted by: gonzo Reported by: Henry Hu <henry.hu.sh@gmail.com> MFH: (blanket: bug/crash fix) Changes: head/www/chromium/files/patch-services_device_hid_hid__connection__freebsd.cc head/www/chromium/files/patch-services_device_hid_hid__connection__freebsd.h head/www/chromium/files/patch-services_device_hid_hid__service__freebsd.cc head/www/chromium/files/patch-services_device_hid_hid__service__freebsd.h Thanks for reporting Henry and thanks for the patch Oleksandr. Tested and committed. Please re-open if necessary. A commit references this bug: Author: jrm Date: Sat Aug 15 21:02:35 UTC 2020 New revision: 545069 URL: https://svnweb.freebsd.org/changeset/ports/545069 Log: MFH: r545067 r545068 www/chromium: Update to version 84.0.4147.125 Upstream changes: https://chromereleases.googleblog.com/2020/08/stable-channel-update-for-desktop.html -- www/chromium: Fix U2F authentication PR: 247744 Submitted by: gonzo Reported by: Henry Hu <henry.hu.sh@gmail.com> Approved by: ports-secteam (blanket) Changes: _U branches/2020Q3/ branches/2020Q3/www/chromium/Makefile branches/2020Q3/www/chromium/distinfo branches/2020Q3/www/chromium/files/patch-services_device_hid_hid__connection__freebsd.cc branches/2020Q3/www/chromium/files/patch-services_device_hid_hid__connection__freebsd.h branches/2020Q3/www/chromium/files/patch-services_device_hid_hid__service__freebsd.cc branches/2020Q3/www/chromium/files/patch-services_device_hid_hid__service__freebsd.h |