Bug 247765

Summary:	kyua needs to flag directory cleanup failures as broken tests
Product:	Base System	Reporter:	Enji Cooper <ngie>
Component:	tests	Assignee:	Enji Cooper <ngie>
Status:	Open ---
Severity:	Affects Some People
Priority:	Normal
Version:	Unspecified
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247761

Description Enji Cooper freebsd_committer

2020-07-04 17:18:14 UTC

From https://github.com/jmmv/kyua/issues/142 :

> @jmmv: If a test case causes the automatic cleanup of its work directory to fail within Kyua, then the test needs to be marked as broken. The current code from HEAD does not do that (only warnings are logged to the log file) though I have not yet validated if this is a regression in the new executor code.

In short, we should flag failures to clean up directories (example: bug 247761) as broken tests to simplify test/kyua use. Users shouldn't have to manually intervene to remove directories/files when resetting system state, unless `kyua debug` is used (this case is "by design").

Comment 1 Enji Cooper freebsd_committer

2020-07-04 17:19:55 UTC

(In reply to Enji Cooper from comment #0)

That didn't render as I would like. Let's try this again..

> @jmmv: If a test case causes the automatic cleanup of its work directory to fail
> within Kyua, then the test needs to be marked as broken. The current code from HEAD
> does not do that (only warnings are logged to the log file) though I have not yet
> validated if this is a regression in the new executor code.