Bug 247884
| Summary: | New port: www/gwsocket Simple WebSocket Server | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Morante <daniel> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Tobias C. Berner <tcberner> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | diizzy, tcberner | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Daniel Morante
2020-07-10 05:51:38 UTC
Created attachment 216357 [details]
SVN diff
Removed UTF8 option (not supported).
GNU_CONFIGURE and INSTALL_TARGET seem out of place, portlint doesn't complain? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-samplem.html CFLAGS and LDFLAGS can't be replace by USES= localbase ? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-localbase.html Any specific reason why you're using a fairly dynamic approach to pkg-plist? https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-autoplist.html https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-dynamic.html Does it pass Poudreire? Best regards, Daniel (In reply to daniel.engberg.lists from comment #2) Thank you for the feedback. Portlint only warned about the absolute path names for "/var/run/.." and "/var/log". This Makefile was derived from an existing port and I missed double checking that. Regardless, I moved the GNU_CONFIGURE line to more sensible placement and removed INSTALL_TARGET since it seems to have no effect. I also made a few changes to the pkg-list according to your suggestions, and got rid of the CFLAGS and LDFLAGS lines since those are also unnecessary. While making the above changed I discovered an error with the way the OPENSSL option was being applied and fixed it. The port passes Poudreire: https://pkg.ny-us.morante.net/poudriere/data/12amd64-default/2020-07-10_23h56m28s/logs/gwsocket-0.3.log Created attachment 216372 [details]
SVN diff
Updated svn diff with corrections.
Created attachment 216373 [details]
SVN diff
Upload correct patch.
LGTM, nice work! Poudriere testport OK 12.1-RELEASE (amd64) Committed, thanks. A commit references this bug: Author: tcberner Date: Sat Aug 15 05:30:43 UTC 2020 New revision: 544909 URL: https://svnweb.freebsd.org/changeset/ports/544909 Log: New port: www/gwsocket Simple WebSocket Server gwsocket is a simple, standalone, language-agnostic, RFC6455 compliant WebSocket Server, written in C. It sits between your application and the client's browser, giving fast bidirectional communication between these two with ease and flexibility. More info at: http://gwsocket.io. PR: 247884 Submitted by: Daniel Morante <daniel@morante.net> Changes: head/www/Makefile head/www/gwsocket/ head/www/gwsocket/Makefile head/www/gwsocket/distinfo head/www/gwsocket/files/ head/www/gwsocket/files/gwsocket.conf head/www/gwsocket/files/gwsocket.in head/www/gwsocket/files/pkg-message.in head/www/gwsocket/files/sample.html head/www/gwsocket/pkg-descr head/www/gwsocket/pkg-plist |
