Bug 247950
| Summary: | dns/bind911 and dns/bind916: lmdb-0.9.24_2,1 causes problems with bind dynamic zones after reload | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | david | ||||||
| Component: | Individual Port(s) | Assignee: | Mathieu Arnold <mat> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | delphij, mat | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
(In reply to david from comment #0) Thanks for the report. I have looked at ISC repository and found that it's actually an known upstream issue: https://gitlab.isc.org/isc-projects/bind9/-/issues/1976 It seems that there were some architectural difference that would make it hard to fix it in BIND itself, so the upstream decided to solve it (for now) with doing the locking in BIND itself instead of relying on LMDB. I'll post a patch to fix this for BIND 9.16 which worked for me for mat@'s approval. Created attachment 216456 [details] dns/bind916: Apply upstream change of LMDB locking. Full background at https://gitlab.isc.org/isc-projects/bind9/-/issues/1976 Created attachment 216457 [details]
dns/bind911: Apply upstream change of LMDB locking
Over to maintainer. I will have a look next week. (In reply to Mathieu Arnold from comment #5) Thanks! Note that this would be part of next release of BIND, so if you are updating them soon, please feel free to just use the next release and disregard this patchset. Mmmm, does it need to be merged to the current quartely branch? I have a hard time figuring out if it is needed or not. A commit references this bug: Author: mat Date: Mon Jul 20 13:50:14 UTC 2020 New revision: 542640 URL: https://svnweb.freebsd.org/changeset/ports/542640 Log: Fix rndc with LMDB 0.9.26+. PR: 247950 Submitted by: delphij Reportedy: david isnic is Obtained from: https://gitlab.isc.org/isc-projects/bind9/-/issues/1976 MFH: 2020Q3 (not sure if needed) Changes: head/dns/bind911/Makefile head/dns/bind911/files/extrapatch-bind-lmdb-lock head/dns/bind916/Makefile head/dns/bind916/files/extrapatch-bind-lmdb-lock closing. If this needs to be merged to the quarterly branch, please reopen. |
Since lmdb-0.9.24_2,1 bind with dynamic zones has problems after HUP. This happens in our setup every night when newsyslog runs. It seems the fix in #244493 may have issues. Steps to reproduce: * Install bind (bind911 and bind916 both tested) * Add "allow-new-zones yes;" under options section of /usr/local/etc/namedb/named.conf * service named restart * kill -HUP `cat /var/run/named/pid` * rndc -k /usr/local/etc/namedb/rndc.key addzone 'example.org {type slave; masters { 127.0.0.1;}; file "/usr/local/etc/namedb/slave/example.org";};' * Check /var/log/messages, find errors like: Jul 13 14:05:57 davidtest named[74867]: mdb_txn_begin: Invalid argument Jul 13 14:05:57 davidtest named[74867]: mdb_txn_begin: Invalid argument We've downgraded to lmdb-0.9.24_1,1 which does not have this problem.