Summary: | security/yubico-piv-tool: Fails to build under 11.3-RELEASE with DEFAULT_VERSIONS=ssl=openssl | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Craig Leres <leres> | ||||
Component: | Individual Port(s) | Assignee: | Craig Leres <leres> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(ume) |
||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Craig Leres
2020-07-17 17:10:23 UTC
Created attachment 216517 [details]
patch
A commit references this bug: Author: leres Date: Fri Jul 31 19:53:38 UTC 2020 New revision: 543880 URL: https://svnweb.freebsd.org/changeset/ports/543880 Log: security/yubico-piv-tool: Unbreak build on FreeBSD 11 with DEFAULT_VERSIONS=ssl=openssl r541879 adds a patch that disables an openssl cmake module from being invoked. But on 11.3 at least if some other package dependency pulls in openssl (or DEFAULT_VERSIONS has ssl=openssl), yubico-piv-tool is built with openssl 1.0 includes from base and openssl 1.1 libraries from the port; this fails due to openssl API changes between 1.0 and 1.1 (e.g. EVP_MD_CTX_create() became EVP_MD_CTX_new()). This is not a compile time problem on 12.1 because the base version of openssl is 1.1 (but there is no guarantee there are not other issues caused by the mixing of includes and libraries). Replace the CMakeLists.txt patch with one for patch-cmake_openssl.cmake that the cmake checks for openssl/libcrypto optional. This ensures that openssl includes and libraries are not mixed between the base and ports versions. PR: 248049 Approved by: ume (maintainer timeout, 2 weeks) Changes: head/security/yubico-piv-tool/files/patch-CMakeLists.txt head/security/yubico-piv-tool/files/patch-cmake_openssl.cmake The fix has been committed. |