Bug 248164
| Summary: | devel/libvirt: And other ports fail to configure with security/libssh2: configure: error: You must install the libssh2 >= 1.3 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | dgilbert | ||||||||||
| Component: | Individual Port(s) | Assignee: | Roman Bogorodskiy <novel> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | james, novel | ||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(sbz) koobs: maintainer-feedback? (novel) |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
dgilbert
2020-07-22 04:23:54 UTC
I'm unable to recreate this using either the default options for libssh2 & libssh or your specific selection of options for those ports. I'm wondering if there is some issue with your build of the libssh2 package. It may be worth rebuilding it (remove it from the poudriere package dir and let it recreate it). Are you able to post a config.log from one of these packages (poudriere testport -i) so we can see what's going on please? Might be worth poking around and seeing if libssh2 is actually installed correctly in the jail. In any case, I am fairly certain this bug isn't an issue with devel/libvirt and is either setup related or an issue with security/libssh2. On a bit of further poking, I *was* able to recreate this. I may have built the wrong set when running poudriere testport which is why I couldn't get it to go earlier. You have security/libssh2 configured with GCRYPT=on. This is the option that is causing this to fail. Incidentally, you have libssh configured with GCRYPT=off - not sure if this is intended or not. I'll poke libssh2 a bit more and see if I can figure out what the difference is. Ok, this is definitely a security/libssh2 bug, the pkg-config file does not get properly set up for gcrypt. So it still looks for open/libressl in /use/local instead - which Poudriere won't have installed. I'm out of time to troubleshoot for right now . I'll come back to it in a few hours unless someone submits a patch in the interim. Looks like the libssh2 port is using configure flags (--with-gcrypt, --with-openssl) there were renamed quite some time ago: https://github.com/libssh2/libssh2/commit/e70e71a3b18b43064b03e460a645dac152c9122c#diff-67e997bcfdac55191033d57a16d1408a Created attachment 216654 [details]
Patch for libssh2
Ah perfect, correcting those options seems to properly resolve everything. The existing logic in the port should stay to address SSL if using something other than base.
Build logs to follow.
Created attachment 216655 [details]
libssh2 build log post patch
Created attachment 216656 [details]
libvirt build log post patch
A commit references this bug: Author: novel Date: Sat Aug 8 05:17:01 UTC 2020 New revision: 544360 URL: https://svnweb.freebsd.org/changeset/ports/544360 Log: security/libssh2: fix the GCRYPT option The port uses the old crypto configure flags: --with-libgcrypt and --with-openssl. These flags are no longer supported. Besides from the obvious effect of the actual port configuration not matching user intent, it also produces incorrect pkg-config file for the given set of dependencies, and other ports that depend on libssh2 fail when it's configured with GCRYPT=on. Fix by using the proper configure arguments: --with-crypto=libgcrypt and --with-crypto=openssl. PR: 248164 Submitted by: dgilbert@eicat.ca (bug report), James French (patch) Approved by: maintainer timeout Changes: head/security/libssh2/Makefile Committed, thanks for reporting and submitting patches. |
