Bug 248170
| Summary: | sysutils/rovclock: fix build on aarch64, armv6, armv7, mips, mips64, powerpc64 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
| Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | Keywords: | needs-qa | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(danfe) koobs: merge-quarterly? |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 216659 [details]
patch
Approved by: portmgr (blanket: build fix (multiple archs)
MFH: 2020Q3 (blanket: build fix (multiple archs)
Is this patch able to upstream?
(In reply to Kubilay Kocak from comment #1) Well, I only added some additional lines to the already existing patch. I suppose if the original patch couldn't be upstreamed, new content also won't be upstreamed. A commit references this bug: Author: pkubaj Date: Wed Jul 22 22:03:48 UTC 2020 New revision: 542896 URL: https://svnweb.freebsd.org/changeset/ports/542896 Log: sysutils/rovclock: fix build on aarch64, armv6, armv7, mips, mips64, powerpc64 Probably other architectures are also fixed but only those are marked broken. machine/pio.h is necessary for outl(). PR: 248170 Approved by: portmgr (blanket: build fix (multiple archs)) MFH: 2020Q3 (blanket: build fix (multiple archs)) Changes: head/sysutils/rovclock/Makefile head/sysutils/rovclock/files/patch-rovclock.c A commit references this bug: Author: pkubaj Date: Wed Jul 22 22:04:44 UTC 2020 New revision: 542897 URL: https://svnweb.freebsd.org/changeset/ports/542897 Log: MFH: r542896 sysutils/rovclock: fix build on aarch64, armv6, armv7, mips, mips64, powerpc64 Probably other architectures are also fixed but only those are marked broken. machine/pio.h is necessary for outl(). PR: 248170 Approved by: portmgr (blanket: build fix (multiple archs)) Changes: _U branches/2020Q3/ branches/2020Q3/sysutils/rovclock/Makefile branches/2020Q3/sysutils/rovclock/files/patch-rovclock.c I don't get it: why file the PR which would be assigned it to me and then commit in less than 10 hours without waiting for any input from the maintainer? If you never wanted/needed any reaction, then please do not open PRs and just commit what you want to commit. (In reply to Alexey Dokuchaev from comment #5) I did want to get approval to be sure that this will be ok, but it was approved by koobs. |
Created attachment 216659 [details] patch Probably other architectures are also fixed but those are marked broken.