Bug 248208
| Summary: | security/pssh: switch to the most viable fork | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Pavel Timofeev <timp87> | ||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | fernape | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Full changelog available at https://github.com/lilydjwg/pssh/blob/master/ChangeLog Any objections to this? Thanks for the patch. The upstream project, seems to provide releases (https://github.com/lilydjwg/pssh/releases/tag/v2.3.4). Would you change the patch to use MASTER_SITES instead of USE_GITHUB? Thanks! (In reply to Fernando Apesteguía from comment #3) I didn't understand how to use MASTER_SITES instead of USE_GITHUB. There are no examples on Porters Handbook (at least I counld't find them) and I couldn't find other existing port which does it. Could you please explain a bit more? Moreover if I set MASTER_SITES to https://github.com/bla/bla then ports framework complains that I'm going it wrong and I should use USE_GITHUB instead /!\ pssh-2.3.4: Makefile warnings, please consider fixing /!\ MASTER_SITES contains https://github.com/lilydjwg/pssh/archive/, please use USE_GITHUB instead. (In reply to timp87 from comment #5) Try something like this: MASTER_SITES= https://github.com/lilydjwg/pssh/releases/download/v${PORTVERSION}/ (In reply to Fernando Apesteguía from comment #6) Seems like release made a bit wrong since there are no assets there (In reply to timp87 from comment #7) Yes, I seems the release is not viable. Thanks for checking though. Build testing... A commit references this bug: Author: fernape Date: Fri Aug 7 18:41:58 UTC 2020 New revision: 544341 URL: https://svnweb.freebsd.org/changeset/ports/544341 Log: security/pssh: update to 2.3.4 ChangeLog https://github.com/lilydjwg/pssh/blob/master/ChangeLog * switch to the most viable fork * Set MAINTAINER PR: 248208 Submitted by: timp87@gmail.com Changes: head/security/pssh/Makefile head/security/pssh/distinfo head/security/pssh/files/patch-psshlib_cli.py head/security/pssh/files/patch-psshlib_manager.py head/security/pssh/files/patch-psshlib_psshutil.py head/security/pssh/pkg-descr Committed, Thanks! |
Created attachment 216705 [details] port patch Original PSSH is dead. There are multiple patches exist in the internet that will probably never land. Instead of digging it follow Fedora way - use the most viable fork of the original PSSH maintained by 'lilydjwg' github user. It incorporated those patches and looks really alive! - upstream to switch to the most viable fork by lilydjwg - take the latest release - remove upstreamed patches - take maintanership - update pkg-descr to reflect the changes - drop python 2 support since the fork works only with 3.5+