Bug 248285
| Summary: | [NEW PORT] security/intel-ipsec-mb: Intel(R) Multi-Buffer Crypto for IPsec Library | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Martin Filla <freebsd> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Vanilla I. Shu <vanilla> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | diizzy, swills, vanilla | ||||||||||||
| Priority: | --- | ||||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 216937 [details]
intel-ipsec-mb.shar
Hi, plist seems to be missing? Upstream uses tags which is a bit nicer looking that commit hash https://github.com/intel/intel-ipsec-mb/tags so you can probably drop GH_TAGNAME. Remove localbase:ldflags if it's not used/required? Any reason why we're building a static library instead of a shared (perhaps add a menu option)? Please reference upstream PRs etc which makes it a lot easier when updating the port. Best regards, Daniel (In reply to daniel.engberg.lists from comment #2) This hash is 260 commits past the tag for 0.54, so we shouldn't call this 0.54. Created attachment 217044 [details]
updated shar
This look OK?
Created attachment 217045 [details]
updated shar
Oops, missed some things. This looks better.
That looks better although I'm not sold on not using release versions unless it's for a very good reason (personal opinion). Unless we have any direct users of this port I think it would be better to ask/wait for upstream to do a proper release since master branch seems to include multiple fixes for FreeBSD, also is the patch upstreamed or a commit/PR from upstream? Given that extensive usage of special CPU instructions I think it would be nice if we could get a "make test" target so we don't compile libraries that doesn't run at all. Created attachment 217052 [details]
intel-ipsec-mb.shar
New update with tests
A commit references this bug: Author: vanilla Date: Sun Sep 13 12:52:19 UTC 2020 New revision: 548475 URL: https://svnweb.freebsd.org/changeset/ports/548475 Log: Add intel-ipsec-mb g20200801, intel(R) Multi-Buffer Crypto for IPsec Library. PR: 248285 Submitted by: freebsd@sysctl.cz Changes: head/security/Makefile head/security/intel-ipsec-mb/ head/security/intel-ipsec-mb/Makefile head/security/intel-ipsec-mb/distinfo head/security/intel-ipsec-mb/files/ head/security/intel-ipsec-mb/files/patch-perf_ipsec__perf.c head/security/intel-ipsec-mb/pkg-descr Committed, thanks. |
Created attachment 216789 [details] intel-ipsec-mb.shar Hi, I made a port security/intel-ipsec-mb M.