|Summary:||net/mtr: Fails to package PREFIX != LOCALBASE|
|Product:||Ports & Packages||Reporter:||John Hein <jcfyecrayz>|
|Component:||Individual Port(s)||Assignee:||Po-Chuan Hsieh <sunpoet>|
|Severity:||Affects Some People||CC:||sunpoet|
Description John Hein 2020-07-30 22:39:08 UTC
Created attachment 216895 [details] [patch] provide explicit configure option for bash completions dir There is a plist error if bash-completion is installed and PREFIX != LOCALBASE ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: /usr/loc/share/bash-completion/completions/mtr Error: Orphaned: @dir /usr/loc/share/bash-completion/completions Error: Orphaned: @dir /usr/loc/share/bash-completion ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: share/bash-completion/completions/mtr The attached patch provides an explicit configure option for --with-bash-completiondir. It also moves USES to make portlint happy.
Comment 1 John Hein 2020-07-30 22:43:34 UTC
Created attachment 216896 [details] [patch] provide explicit configure option for bash completions dir (v2) Re-gen patch against latest version of mtr/Makefile.
Comment 2 John Hein 2020-07-30 22:47:17 UTC
QA: - confirmed 'make stage check-plist' failure in poudriere with bash-completion installed before applying patch - confirmed success in poudriere after patch
Comment 3 Kubilay Kocak 2020-08-01 04:47:45 UTC
Comment on attachment 216896 [details] [patch] provide explicit configure option for bash completions dir (v2) Approved by: portmgr (blanket: packaging fix) MFH: 2020Q3 (blanket: packaging fix)
Comment 4 Po-Chuan Hsieh 2020-08-02 05:06:08 UTC
(In reply to Kubilay Kocak from comment #3) No. That does not work.
Comment 5 Po-Chuan Hsieh 2020-08-02 05:17:48 UTC
(In reply to John Hein from comment #0) I do not really understand the use case that PREFIX != LOCALBASE. Since it now installs the bash completion to PREFIX, the PLIST has to be changed as well.
Comment 6 John Hein 2020-08-02 16:33:06 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #5) As described in the first sentence of this bug report, if bash-completion is installed, net/mtr does not install to PREFIX. To perhaps help clarify that: this happens because 'configure' uses 'pkgconf --variable completionsdir bash-completion' if bash-completion is installed to determine the install location (which will not necessarily be under PREFIX). If bash-completion is not installed, then it uses a fallback value that is under PREFIX. How to reproduce: sudo make -C /usr/ports/shells/bash-completion install sudo make -C /usr/ports/net/mtr stage check-plist PREFIX=/opt (In reply to Sunpoet Po-Chuan Hsieh from comment #4) "No. That does not work." --- _What_ does not work?