Summary: | emulators/virtualbox-ose-additions: Build fails with 13-CURRENT base r363894 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yasuhiro Kimura <yasu> | ||||||
Component: | Individual Port(s) | Assignee: | Virtualbox Team (Nobody) <vbox> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | madpilot, vvd | ||||||
Priority: | --- | Keywords: | needs-qa, regression | ||||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(vbox) koobs: merge-quarterly? |
||||||
Hardware: | amd64 | ||||||||
OS: | Any | ||||||||
URL: | https://reviews.freebsd.org/D26014 | ||||||||
Attachments: |
|
Description
Yasuhiro Kimura
2020-08-08 07:29:35 UTC
Created attachment 217089 [details] Fix build after r363893: vfs: remove the obsolete privused argument from vaccess /wrkdirs/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.44/src/VBox/Additions/freebsd/vboxvfs/vboxvfs_vnops.c:412:51: error: too many arguments to function call, expected 6, have 7 node->vboxfsmp->sf_gid, accmode, ap->a_cred, NULL)); ^~~~ > return (vaccess(vp->v_type, m, node->vboxfsmp->sf_uid, > node->vboxfsmp->sf_gid, accmode, ap->a_cred, NULL)); man vaccess (on 12.1): int vaccess(enum vtype type, mode_t file_mode, uid_t file_uid, gid_t file_gid, accmode_t accmode, struct ucred *cred, int *privused); > After update 13-CURRENT to base r36403, build fails as following. Date: Wed May 27 01:26:33 1998 UTC (22 years, 2 months ago) This commit break build: https://svnweb.freebsd.org/changeset/base/363893 Try to replace file emulators/virtualbox-ose/files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c with version in attach. I have filed a patch here: https://reviews.freebsd.org/D26014 My patch simply removes the extra NULL value to the privused argument. I'd like to get approval to commit that review. (In reply to Guido Falsi from comment #2) I meant, simply removes it when building on recent current, obviously :) (In reply to Guido Falsi from comment #3) node->vboxfsmp->sf_gid, accmode, ap->a_cred #if __FreeBSD_version < 1300105 , NULL #endif )); @Guido Does your patch obsolete attachment 217089 [details]?
(In reply to Kubilay Kocak from comment #5) My patch applicable for 13 only - I made it for testing purposes only. Guido's patch work for 11 and 12 too. But I wrote suggestion in comment #4 to his patch. Created attachment 217131 [details]
Fix build after r363893: vfs: remove the obsolete privused argument from vaccess
Patch with my suggestion to @Guido's patch.
(In reply to VVD from comment #7) Thanks for the update, I've aligned the code review. The problem is fixed with ports r544827. |