Bug 248721

Summary: audio/hydrogen Fix build with LIBTAR option
Product: Ports & Packages Reporter: Shane <FreeBSD>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Some People CC: danfe
Priority: --- Keywords: needs-qa
Version: LatestFlags: FreeBSD: maintainer-feedback+
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
See Also: https://github.com/hydrogen-music/hydrogen/issues/928
Attachments:
Description Flags
extra patch for audio/hydrogen FreeBSD: maintainer-approval+

Description Shane 2020-08-18 09:42:09 UTC
Created attachment 217304 [details]
extra patch for audio/hydrogen

audio/hydrogen has an option to choose between libtar and libarchive. The libtar option currently fails, this patch fixes the libtar build.

See https://github.com/hydrogen-music/hydrogen/issues/928
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-18 11:15:30 UTC
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first
Comment 2 Shane 2020-08-19 03:04:34 UTC
Is that for the report or the patch? or both.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-10-26 08:24:26 UTC
A commit references this bug:

Author: danfe
Date: Mon Oct 26 08:23:41 UTC 2020
New revision: 553324
URL: https://svnweb.freebsd.org/changeset/ports/553324

Log:
  Unbreak the build against non-default LIBTAR option.

  PR:	248721

Changes:
  head/audio/hydrogen/files/patch-src_gui_src_SoundLibrary_SoundLibraryExportDialog.cpp
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2020-10-26 08:27:13 UTC
Patch added with ports r553324, thank you.