Bug 248733
| Summary: | graphics/exiv2: add NLS option | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrew Romanenko <melanhit> | ||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | diizzy, riggs | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi, Good idea, a few things I noticed and/or have questions about. No need to bump PORTREVISION as there's no change to the package. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html - 5.13.1.3 --> L33 unnecessary Have you compiled both with and without NLS support and verified that "make test" passes? Have you verified that LDFLAGS variable isn't needed? Best regards, Daniel Created attachment 217492 [details] exiv2.patch build OK with- and without NLS forced linking with -lintl was needed for gcc-archs https://svnweb.freebsd.org/ports/head/graphics/exiv2/Makefile?revision=485731&view=markup We still do have archs that uses GCC (legacy) A commit references this bug: Author: riggs Date: Sat Sep 26 12:09:37 UTC 2020 New revision: 550175 URL: https://svnweb.freebsd.org/changeset/ports/550175 Log: Add NLS option. PR: 248733 Submitted by: melanhit@gmail.com Reviewed by: daniel.engberg.lists@pyret.net, riggs Changes: head/graphics/exiv2/Makefile head/graphics/exiv2/pkg-plist Committed a slight modification that (I think) will keep the legacy-gcc archs happy for now. |
Created attachment 217318 [details] exiv2.patch add NLS option, enabled by default. also removed forced linking with libintl. build via poudriere ok (12.1-STABLE/amd64)