Bug 248741

Summary: net/mpd5: Fix build with -fno-common (clang 11 and gcc 10)
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Eugene Grosbein <eugen>
Status: Closed FIXED    
Severity: Affects Some People Flags: eugen: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 248756    
Attachments:
Description Flags
Fix build with -fno-common (clang 11 and gcc 10) none

Description Dimitry Andric freebsd_committer freebsd_triage 2020-08-18 21:11:59 UTC 
Created attachment 217326 [details]
Fix build with -fno-common (clang 11 and gcc 10)

In base r364284, I imported clang 11 into head. Like gcc 10, it now defaults to -fno-common, meaning that duplicated global symbols will most likely lead to link errors. Here is a patch to fix this port's duplicated global symbols.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-08-20 08:13:45 UTC 
A commit references this bug:

Author: eugen
Date: Thu Aug 20 08:13:08 UTC 2020
New revision: 545507
URL: https://svnweb.freebsd.org/changeset/ports/545507

Log:
  net/mpd5: import r2272 from upstream

  This fixes build with -fno-common (clang 11 and gcc 10).
  PORTREVISION not bumped as it fixes build for FreeBSD 13.

  PR:		248741
  Reported by:	dim

Changes:
  head/net/mpd5/files/patch-auth.h
Comment 2 Eugene Grosbein freebsd_committer freebsd_triage 2020-08-20 08:15:18 UTC 
Fixed with simplier patch. Thank you for the report!