Bug 248743

Summary: net-mgmt/iftop: Fix build with -fno-common (clang 11 and gcc 10)
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Vasil Dimov <vd>
Status: Closed FIXED    
Severity: Affects Many People Flags: vd: maintainer-feedback+
koobs: merge-quarterly?
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 248756    
Attachments:
Description Flags
Fix build with -fno-common (clang 11 and gcc 10) none

Description Dimitry Andric freebsd_committer freebsd_triage 2020-08-18 21:12:07 UTC 
Created attachment 217328 [details]
Fix build with -fno-common (clang 11 and gcc 10)

In base r364284, I imported clang 11 into head. Like gcc 10, it now defaults to -fno-common, meaning that duplicated global symbols will most likely lead to link errors. Here is a patch to fix this port's duplicated global symbols.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-09-01 11:50:24 UTC 
A commit references this bug:

Author: vd
Date: Tue Sep  1 11:50:20 UTC 2020
New revision: 547265
URL: https://svnweb.freebsd.org/changeset/ports/547265

Log:
  net-mgmt/iftop: fix build with -fno-common (clang11/gcc10)

  PR:		248743
  Submitted by:	dim
  MFH:		2020Q3 (build fix)

Changes:
  head/net-mgmt/iftop/files/
  head/net-mgmt/iftop/files/patch-ui__common.c
  head/net-mgmt/iftop/files/patch-ui__common.h
Comment 2 Vasil Dimov freebsd_committer freebsd_triage 2020-09-01 11:59:22 UTC 
Committed, thanks!