Bug 248776

Summary: irc/znc-push: update to g5f95488 and fix builx with CURL option ON
Product: Ports & Packages Reporter: Daniel <d.stoye>
Component: Individual Port(s)Assignee: Fernando ApesteguĂ­a <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: dor.bsd, fernape
Priority: --- Flags: dor.bsd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
irc/znc-push: Fix CURL option and update dor.bsd: maintainer-approval+

Description Daniel 2020-08-20 11:07:31 UTC
This Port currently does not build when Option "CURL" is selected.
Fails with: 

    /usr/bin/c++ -O2 -pipe -fstack-protector-strong -fno-strict-aliasing   -DPUSHVERSION="\"1.0.0.167\"" -DUSE_CURL -lcurl  -fstack-protector-strong  CMakeFiles/cmTC_2218a.dir/testCXXCompiler.cxx.o -o cmTC_2218a
    ld: error: unable to find library -lcurl
Comment 1 Daniel 2020-08-20 11:13:44 UTC
-L/usr/local/lib is Missing as argument in the Makefile, i guess
Comment 2 David O'Rourke 2020-08-20 16:17:04 UTC
Thanks for the report. I'm looking at fixing this now.
Comment 3 David O'Rourke 2020-08-20 17:15:46 UTC
Created attachment 217390 [details]
irc/znc-push: Fix CURL option and update

This patch fixes the CURL option by adding `localbase:ldflags` to `USES`, and updates the port to the latest available upstream code, 1.0.0-167-g5f95488.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-08-20 18:13:27 UTC
A commit references this bug:

Author: fernape
Date: Thu Aug 20 18:13:14 UTC 2020
New revision: 545544
URL: https://svnweb.freebsd.org/changeset/ports/545544

Log:
  irc/znc-push: update to g5f95488

  Also fix build with CURL option ON

  PR:	248776
  Submitted by:   dor.bsd@xm0.uk (maintainer)
  Reported by:    d.stoye@cms.hu-berlin.de

Changes:
  head/irc/znc-push/Makefile
  head/irc/znc-push/distinfo
Comment 5 Fernando ApesteguĂ­a freebsd_committer freebsd_triage 2020-08-20 18:13:44 UTC
Committed,

Thanks!